? Pending

User tests: Successful: Unsuccessful:

avatar ReLater
ReLater
6 Nov 2018

Pull Request for Issue #22954 .

Testing Instructions

See #22954

Expected result

  • No warning if plugin is not named standard conform
avatar ReLater ReLater - open - 6 Nov 2018
avatar ReLater ReLater - change - 6 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Nov 2018
Category Administration
avatar brianteeman
brianteeman - comment - 6 Nov 2018

this "naming convention" must be documented

avatar mbabker
mbabker - comment - 6 Nov 2018

There isn't a forced convention for extension names (as used in the manifest). Chuck defining that convention into the same pile as defining a convention for the extension XML filenames and hope it gets a result.

avatar BertaOctech
BertaOctech - comment - 16 Nov 2018

I have tested this item ? unsuccessfully on 97b7f86

I creted a custom field with superadmin permits
I submited an article as editor.
I had the same result with or without the patch applied

When I tried to save the article I could not because I got the error "Invalid field: campo-editores"


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22955.

avatar BertaOctech BertaOctech - test_item - 16 Nov 2018 - Tested unsuccessfully
avatar Quy
Quy - comment - 16 Nov 2018

@BertaOctech This PR does not address your issue. Please test PR #22923.

avatar twister65
twister65 - comment - 19 Nov 2018

The naming convention is also very important to update a plugin, otherwise the update does not work.

avatar twister65
twister65 - comment - 19 Nov 2018

After applying this patch (loadTranslationFiles), I have:
User twister65 installed the plugin PLG_EASYJOOMLABACKUPCRONJOB
It would be better to have :
User twister65 installed the plugin System - EJB Cronjob - Easy Joomla Backup Cronjob

The translation failed.

avatar ReLater
ReLater - comment - 19 Nov 2018

This pr is just for avoiding the warning at the current code state. Not more.

So I think, you have tested this pr successfully.

I don't think that you can force a naming convention for all these for a long time established extensions without a shitstorm. Would be nice but ...

avatar twister65
twister65 - comment - 1 Dec 2018

I have tested this item successfully on 97b7f86


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22955.

avatar twister65 twister65 - test_item - 1 Dec 2018 - Tested successfully
avatar Quy
Quy - comment - 1 Dec 2018

I have tested this item successfully on 97b7f86


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22955.

avatar Quy Quy - change - 1 Dec 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 1 Dec 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22955.

avatar Quy Quy - test_item - 1 Dec 2018 - Tested successfully
avatar mbabker mbabker - change - 1 Dec 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-12-01 18:07:49
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 1 Dec 2018
avatar mbabker mbabker - merge - 1 Dec 2018

Add a Comment

Login with GitHub to post a comment