? Pending

User tests: Successful: Unsuccessful:

avatar GeraintEdwards
GeraintEdwards
6 Nov 2018

Pull Request for Issue # .

Summary of Changes

search filter in getListQuery in ActionlogsModelActionlogs uses the wrong substring when searching by item_id: - it is set to remove the first 3 chars (as per 'id:') instead of 8 (as per 'item_id:')

Testing Instructions

Make sure ActionLogs are enabled for com_content and that action logs system plugin is enabled.

Edit and save an article. View the action logs and you should see something like this

User admin updated the article Create Article Test

Hover over the article link to see the article id (in my case it is id=4) - then put it in the text search vox as

item_id:4

Expected result

Should see list of actions related to the article 'Create Article Test' (and possibly other actions if you don't also filter by extension ;) )

Actual result

You get no results since the existing code converts the string "m_id:4" to the integer zero and gets no matching results

Documentation Changes Required

None

avatar GeraintEdwards GeraintEdwards - open - 6 Nov 2018
avatar GeraintEdwards GeraintEdwards - change - 6 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Nov 2018
Category Administration
avatar Quy
Quy - comment - 6 Nov 2018

I have tested this item successfully on 2853b0f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22948.

avatar Quy
Quy - comment - 6 Nov 2018

I have tested this item successfully on 2853b0f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22948.

avatar Quy Quy - test_item - 6 Nov 2018 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 6 Nov 2018

I have tested this item successfully on 2853b0f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22948.

avatar SharkyKZ SharkyKZ - test_item - 6 Nov 2018 - Tested successfully
avatar Quy Quy - change - 6 Nov 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 6 Nov 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22948.

avatar mbabker mbabker - change - 10 Nov 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-11-10 15:53:18
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 10 Nov 2018
avatar mbabker mbabker - merge - 10 Nov 2018

Add a Comment

Login with GitHub to post a comment