J4 Issue ?
avatar BPBlueprint
BPBlueprint
6 Nov 2018

Steps to reproduce the issue

e.g. custom module, when used with style="none"

Expected result

<div class="mod-custom custom my-own-class">

Actual result

<div class="mod-custom custom">

System information (as much as possible)

Joomla 4.0 Alpha5

Additional comments

avatar BPBlueprint BPBlueprint - open - 6 Nov 2018
avatar joomla-cms-bot joomla-cms-bot - change - 6 Nov 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 6 Nov 2018
avatar BPBlueprint BPBlueprint - change - 6 Nov 2018
The description was changed
avatar BPBlueprint BPBlueprint - edited - 6 Nov 2018
avatar laoneo
laoneo - comment - 6 Nov 2018

Can you provide us a bit more detailed steps how we can reproduce the issue?

avatar BPBlueprint
BPBlueprint - comment - 6 Nov 2018

Quite easy:
e.g. modules/mod_custom/tmpl/default.php

instead of
<div class="custom<?php echo $moduleclass_sfx; ?>">
the possibility for additional class echo $moduleclass_sfx now is missing, so that we only have
<div class="mod-custom custom">

This happens when I use in templaes/my-template/index.php the style style="none"
<jdoc:include type="modules" name="position-0" style="none" />

avatar brianteeman
brianteeman - comment - 6 Nov 2018

style = none has never supported a module chrome with a $moduleclass_sfx

This is not a change in Joomla 4

Perhaps the template you used in Joomla 3 had an override for style=none in modules.php

avatar SharkyKZ
SharkyKZ - comment - 6 Nov 2018

Suffix was removed from module layout files in J4.

avatar BPBlueprint
BPBlueprint - comment - 6 Nov 2018

Suffix was removed from module layout files in J4.

Sad to hear this...

avatar brianteeman
brianteeman - comment - 6 Nov 2018

@SharkyKZ sorry you are mistaken - the change was to remove the need for the space at the beginning

<<?php echo $moduleTag; ?> class="moduletable <?php echo htmlspecialchars($params->get('moduleclass_sfx'), ENT_COMPAT, 'UTF-8') . $moduleClass; ?>">

avatar brianteeman brianteeman - change - 6 Nov 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 6 Nov 2018
avatar BPBlueprint
BPBlueprint - comment - 6 Nov 2018

@brianteeman that means, that $moduleclass_sfx will be placed again in layout files?

avatar SharkyKZ
SharkyKZ - comment - 6 Nov 2018

Layouts, not chromes. See #17447.

avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Mar 2019
Status New Information Required
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Mar 2019

@BPBlueprint cn this Issue be closed?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22944.

avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Mar 2019
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2019-03-16 06:59:36
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2019
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 16 Mar 2019
avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Mar 2019
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Mar 2019

Closed as no Response; please reopen if needed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22944.

Add a Comment

Login with GitHub to post a comment