Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#22925] - [3.9.1] Automatic title at Latest Actions Backend Module

? ? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
2 Nov 2018

Pull Request for Issue #22921

Summary of Changes

Fix the automatic title option at the Latest Actions Backend Module

Testing Instructions

Go to Extensions > Modules > Administrator > Latest Actions > Advanced > Automatic Title (ON).
Next go to System > Control panel.

Expected result

Just an updated title: Last %s Actions (where %s is replaced by the count of actions to show)

Actual result

error

Documentation Changes Required

none

avatar zero-24 zero-24 - open - 2 Nov 2018
avatar zero-24 zero-24 - change - 2 Nov 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Nov 2018
Category ⇒ Administration Language & Strings Modules
avatar zero-24 zero-24 - change - 2 Nov 2018
Labels Added: ? ?
avatar Quy
Quy - comment - 3 Nov 2018

Does it matter if the strings are different Last 5 Actions vs Latest Actions?

avatar zero-24
zero-24 - comment - 3 Nov 2018

Does it matter if the strings are different Last 5 Actions vs Latest Actions?

I don't get the question?As is the intend to change the title ;) Or do you mean en-GB wise?

avatar alikon
alikon - comment - 3 Nov 2018

I have tested this item ✅ successfully on 7d03e0a

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22925.

avatar alikon alikon - test_item - 3 Nov 2018 - Tested successfully
avatar jsubri
jsubri - comment - 3 Nov 2018

I have tested this item ✅ successfully on 7d03e0a

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22925.

avatar jsubri jsubri - test_item - 3 Nov 2018 - Tested successfully
avatar infograf768
infograf768 - comment - 3 Nov 2018

Please add strings.
return JText::plural('MOD_LATESTACTIONS_TITLE', $params->get('count', 5));
when using JText::plural we expect multiple language strings.

Example
return JText::plural('MOD_LOGGED_TITLE', $params->get('count', 5));

Strings

MOD_LOGGED_TITLE="Last Logged-in Users"
MOD_LOGGED_TITLE_1="Last Logged-in User"
MOD_LOGGED_TITLE_MORE="Last %s Logged-in Users"
avatar infograf768
infograf768 - comment - 5 Nov 2018

I have tested this item ✅ successfully on 9ae1124

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22925.

avatar infograf768
infograf768 - comment - 5 Nov 2018

I have tested this item ✅ successfully on 9ae1124

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22925.

avatar infograf768 infograf768 - test_item - 5 Nov 2018 - Tested successfully
avatar infograf768 infograf768 - change - 5 Nov 2018
Status Pending ⇒ Ready to Commit
Labels
avatar infograf768
infograf768 - comment - 5 Nov 2018

As the last changes only concerned lang strings, no need for further tests.

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22925.

avatar mbabker mbabker - change - 5 Nov 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-11-05 23:16:34
Closed_By ⇒ mbabker
Labels Added: ?
avatar mbabker mbabker - close - 5 Nov 2018
avatar mbabker mbabker - merge - 5 Nov 2018

Add a Comment

Login with GitHub to post a comment