Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#22913] - [4.0] Load the document properly in the exception handler

? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
2 Nov 2018

Summary of Changes

The error page is currently broken. The error document is not set in the application and the active menu is accessed, even when it can't exist.

Testing Instructions

Open a none existing url, which should produce a 404.

Expected result

The error page is displayed.

Actual result

An error is thrown.

avatar laoneo laoneo - open - 2 Nov 2018
avatar laoneo laoneo - change - 2 Nov 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Nov 2018
Category ⇒ Libraries Front End Templates (site)
avatar infograf768
infograf768 - comment - 2 Nov 2018

Test: Create a 404 in frontend with a wrong url
Once the redirect plugin is disabled as it badly breaks all with

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 262144 bytes) in /Applications/MAMP/htdocs/installmulti/joomla40/libraries/src/Event/ErrorEvent.php on line 31 Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 262144 bytes) in /Applications/MAMP/htdocs/installmulti/joomla40/libraries/src/Session/Storage/JoomlaStorage.php on line 132 Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 262144 bytes) in Unknown on line 0 Warning: Unknown: Cannot call session save handler in a recursive manner in Unknown on line 0

With this PR I do not get anymore errors but modules are displayed in the 404 error page

screen shot 2018-11-02 at 12 06 16

avatar laoneo
laoneo - comment - 2 Nov 2018

I'v tracked down the redirect issue. Will make for it another pr. Can you mark this one as tested.

avatar laoneo laoneo - change - 2 Nov 2018
Labels Added: ?
avatar infograf768
infograf768 - comment - 4 Nov 2018

I have tested this item ✅ successfully on 0024fc9

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22913.

avatar infograf768 infograf768 - test_item - 4 Nov 2018 - Tested successfully
avatar laoneo laoneo - close - 5 Nov 2018
avatar laoneo laoneo - merge - 5 Nov 2018
avatar laoneo laoneo - change - 5 Nov 2018
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-11-05 08:19:03
Closed_By ⇒ laoneo

Add a Comment

Login with GitHub to post a comment