[#22909] - Multilang: correcting `Published Request Form Menu Item` url in Privacy Dashboard
- Fixed in Code Base
- 6 Jan 2019
- Medium
- Build: staging
- # 22909
- Diff
- infograf768:privacydashboardmultilanglink
User tests: Successful: Unsuccessful:
Pull Request for Issue #22869 (comment)
Summary of Changes
Correct the link (language included) and the Published/Unpublished status of the Published Request Form Menu Item url, making it totally independent of the site default language when we do have such menu items.
Also when we have no menu item, correcting the Itemid to use the default site language home page one instead of the one set to ALL languages.
Testing Instructions
See #22869 (comment)
Test and test2.
SEF off to see the non-sef url.
After patch
When we have one or multiple menu items:
The url obtained will anyway be the one of the lowest id in case there are multiple menu items of this kind (no change there as we have only one line for an url in the dashboard), but at least:
The Itemid and the language will be the correct ones in case there are multiple menu items, this independantly from the site default language.
Example when there is a fr-FR such menu item
Also, when there is NO menu item, the Itemid used will not be anymore the Itemid of the default home page set to ALL languages, but the one of the default home page for the default site language. That is important concerning modules assignment.
Example when French is default language and the French home page Itemid is 105 while the home set to ALL is 101.
Before patch
After patch
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22909.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks for testing.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22909.
RTC. Thanks for testing.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22909.
| Labels |
Added:
?
?
|
||
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-01-06 16:27:14 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 7d2fb99
With the patch the Itemid is now the id of the default site language instead of *
With SEF off: index.php?option=com_privacy&view=request&Itemid=269&lang=fr
With SEF on: index.php/fr/mon-acces/requete-de-confidentialite
If the menu is unpublished,we have the home menu in the site language /index.php?option=com_privacy&view=request&lang=fr&Itemid=101
I tested on mon-lingual, no regression
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22909.