? ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
31 Oct 2018

Pull Request for Issue #22869

Summary of Changes

Adds direct link to the privacy consent plugin when there is no Privacy policy article defined.

Testing Instructions

make sure no article is defined in the Privacy Consent System plugin parameters

Before patch

No link to the plugin (and no idea what to do when getting The "Not available" button...)

After patch

screen shot 2018-10-31 at 12 13 02

The only other hyperlink for a chack check that "could" be also added is one to the Global Configuration for mailonline, but this is rather obvious.
For menus, it is also quite obvious.
Can be added though if judged necessary in another PR.

avatar infograf768 infograf768 - open - 31 Oct 2018
avatar infograf768 infograf768 - change - 31 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2018
Category Administration Language & Strings
avatar infograf768 infograf768 - change - 31 Oct 2018
The description was changed
avatar infograf768 infograf768 - edited - 31 Oct 2018
avatar brianteeman
brianteeman - comment - 31 Oct 2018

Not everything should have a link. The similar module for mutilingual status does not.

avatar PhilETaylor
PhilETaylor - comment - 31 Oct 2018

Not everything should have a link.

There is no reason why all 4 options cannot have a link to aid the user to fix the issues.

The similar module for mutilingual status does not.

Then maybe that too should be improved. Not all Joomla users are as close to the project as you, Some need help and guidance along the way. Not everything should be a million clicks away from something else.

avatar alikon
alikon - comment - 31 Oct 2018

not so bad imo to guide more newbie's....
already collected similar question's

avatar brianteeman brianteeman - change - 31 Oct 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-10-31 19:14:58
Closed_By brianteeman
Labels Added: ? ?
avatar brianteeman brianteeman - close - 31 Oct 2018
avatar PhilETaylor
PhilETaylor - comment - 31 Oct 2018

Why was this closed?
This issue refers to FOUR items and the PR is for a single item!

On 31 Oct 2018, at 12:27, Brian Teeman notifications@github.com wrote:

Closed #22888.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar Bakual
Bakual - comment - 31 Oct 2018

Reopening as I also don't see a reason to close this. I guess it was by accident.

avatar Bakual Bakual - change - 31 Oct 2018
Status Closed New
Closed_Date 2018-10-31 19:14:58
Closed_By brianteeman
avatar Bakual Bakual - change - 31 Oct 2018
Status New Pending
avatar Bakual Bakual - reopen - 31 Oct 2018
avatar brianteeman
brianteeman - comment - 31 Oct 2018

Sorry it was closed by accident

67f3a43 1 Nov 2018 avatar infograf768 oops
avatar infograf768
infograf768 - comment - 1 Nov 2018

@PhilETaylor
I reopened #22869 as we need to discuss there what we do for the other checks.
I propose we treat this one separately, get it tested (please do) and merged in the mean while.

avatar infograf768
infograf768 - comment - 2 Nov 2018

#22909
is a totally independant PR to correct the Published Request Form Menu Item url in multilang

avatar infograf768 infograf768 - change - 9 Jan 2019
Labels Added: J3 Issue
avatar alikon
alikon - comment - 9 Jan 2019

I have tested this item successfully on d618c8c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22888.

avatar alikon alikon - test_item - 9 Jan 2019 - Tested successfully
avatar chmst
chmst - comment - 10 Jan 2019

I have tested this item successfully on d618c8c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22888.

avatar chmst chmst - test_item - 10 Jan 2019 - Tested successfully
avatar infograf768 infograf768 - change - 10 Jan 2019
Status Pending Ready to Commit
Labels
avatar infograf768
infograf768 - comment - 10 Jan 2019

rtc
tks for testing.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22888.

avatar infograf768
infograf768 - comment - 10 Jan 2019

rtc
tks for testing.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22888.

avatar infograf768 infograf768 - change - 10 Jan 2019
Labels Added: ?
Removed: J3 Issue
avatar infograf768
infograf768 - comment - 10 Jan 2019

@mbabker
I leave this as RTC as the last change was just a missing s in the lang string.
(Tks Mig for finding this typo)

avatar mbabker mbabker - change - 11 Jan 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-01-11 12:42:36
Closed_By mbabker
avatar mbabker mbabker - close - 11 Jan 2019
avatar mbabker mbabker - merge - 11 Jan 2019

Add a Comment

Login with GitHub to post a comment