[#22878] - [4.0] HTML user selection
- Closed
- 14 Jun 2019
- Medium
- Build: 4.0-dev
- # 22878
- Diff
- priiish:edit_button_userSelection
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #22497 .
Summary of Changes
Changed link into button tag so there won't be any difficulties with spacebar usage.
Also no div is created within a span element anymore (invalid html).
Testing Instructions
Have a look at the article menu ("publishing"). Next to "Created By" is the button to select a user.
Expected result
Button is now within a button tag, the div no longer within the span element.
Actual result
As expected.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
| Category | ⇒ | Layout |
| Labels |
Added:
?
|
||
| Title |
|
||||||
after appling this patch the html rendered is:
<div class="input-group">
<input type="text" id="jform_created_by" class="form-control field-user-input-name" value="" placeholder="Select a User" readonly="">
<span class="input-group-append">
<button type="button" class="btn btn-primary button-select" title="Select User"><span class="fa fa-user icon-white" aria-hidden="true"></span></button>
</span>
<div id="userModal_jform_created_by" role="dialog" tabindex="-1" class="joomla-modal modal fade" data-url="index.php?option=com_users&view=users&layout=modal&tmpl=component&required=0&field=jform_created_by" data-iframe="<iframe class="iframe" src="index.php?option=com_users&view=users&layout=modal&tmpl=component&required=0&field=jform_created_by" name="Select User" height="100%" width="100%"></iframe>">
<div class="modal-dialog modal-lg jviewport-width80" role="document">
<div class="modal-content">
<div class="modal-header">
<h3 class="modal-title">Select User</h3>
<button type="button" class="close novalidate" data-dismiss="modal" aria-label="Cancel">
<span aria-hidden="true">×</span>
</button>
</div>
<div class="modal-body jviewport-height60">
</div>
<div class="modal-footer">
<a type="button" class="btn btn-secondary" data-dismiss="modal">Cancel</a></div>
</div>
</div>
</div>
</div>
I have tested this item
applied patch - it does as it says, no errors, could activate with tab/space
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22878.
franz-wohlkoenig
- | Title |
|
||||||
| Closed_Date | 2019-06-14 23:23:11 | ⇒ | 2019-06-14 23:23:12 |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-14 23:23:11 |
| Closed_By | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/22878
Replaced by PR #25206
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22878.
Replaced by PR #25206
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22878.
I have tested this item✅ successfully on 5775862
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22878.