[#22860] - [4.0] Clean the node modules in the media folder on install
- Fixed in Code Base
- 2 Feb 2019
- Medium
- Build: 4.0-dev
- # 22860
- Diff
- Digital-Peak:j4/clean/media
User tests: Successful: Unsuccessful:
Would be good if the node_modules folder get cleaned on install for the media manager. This pr changes the postinstall hook to use ci. This needs a version bumb in the min npm requirements.
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22860.
As requested I tested on windows. other than significantly increasing the install time (which is crazy under windows) it appeared to do what was expected
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22860.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22860.
Temporarily holding with this, because after this doing a double npm ci takes nearly 10 minutes on windows which is clearly not ok. In it's own right the PR is good. just need to see if there's anything we can do with windows
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
sure will do over the Weekend
--
Viele Grüße/ Best Regards
Robert
Am 14. Dezember 2018 um 19:01:41, George Wilson (notifications@github.com)
schrieb:
@rdeutz https://github.com/rdeutz can we upgrade the version of npm on
drone to version 6 (npm@lts ideally) so that we can actually run ci there
please—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#22860 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAchnBL0R2kjk6Un3ca4gYCy51MAWkrhks5u4-eFgaJpZM4YBmEz
.
Thanks :)
Done, composer and node updated to 11.x
I think you need to make a npm update, to update the bindings and add package-lock.json to the PR
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-02 17:59:08 |
| Closed_By | ⇒ | wilsonge |
@brianteeman Are you able to test what is the effect of this on a windows install?