[#22835] - [4.0] Fix missing Language Key, improve legend
- Fixed in Code Base
- 28 Oct 2018
- Medium
- Build: 4.0-dev
- # 22835
- Diff
- chmst:user-debug-legend
User tests: Successful: Unsuccessful:
Summary of Changes
The permission reports for users and usergrpups show a language key instead of a language string.
I suggest to remover this Text completely, as it is obviopus that the legend is a legend.
Additionally I added a space between icon and text to improve the layout.
Testing Instructions
Have a look on the legend of the permission reports before and after patch.
Expected result
No Language Key should be visible
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users |
I have tested this item
After using patch and controlling of: Users > Manage > Permissions, I got following message:
An error has occurred.
0 syntax error, unexpected 'echo' (T_ECHO)
Return To Control Panel
/administrator/index.php?option=com_users&view=debuguser&user_id=604
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22835.
After using patch and controlling of: Users > Manage > Permissions, I got following message:
An error has occurred.
0 syntax error, unexpected 'echo' (T_ECHO)
Return To Control Panel
/administrator/index.php?option=com_users&view=debuguser&user_id=604
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22835.
| Labels |
Added:
?
|
||
Thank you @ChristineWk, could you retest?
@chmst: I just retested apprx. 10 minutes ago including remarks with marked as: successfully - and it's gone?
Will make it again.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22835.
I have tested this item
2nd retest now :-) Can't understand, because hv still open other browser window - logged in with my previous successful statement.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22835.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-28 11:39:24 |
| Closed_By | ⇒ | wilsonge |
Thanks guys!
I wanted to do all the a11y stuff in another PR as there are several other a11y issues on this table. First I wanted to be sure that removing the legend text is accepted. OK? Or schould I do the whole a11y here at once?