? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
27 Oct 2018

Pull Request for Issue #22830

Summary of Changes

$atum =>$cassiopeia

Testing Instructions

patch a clean checkout of the 4.0-dev branch
Run npm install

Expected result

Now the css files are created for cassiopeia

Can be merged on review (I guess)

avatar infograf768 infograf768 - open - 27 Oct 2018
avatar infograf768 infograf768 - change - 27 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Oct 2018
Category Front End Templates (site)
avatar infograf768 infograf768 - change - 27 Oct 2018
Title
[4.0] Correcting Cassioeia scss error
[4.0] Correcting Cassiopeia scss error
avatar infograf768 infograf768 - edited - 27 Oct 2018
avatar ghazal
ghazal - comment - 27 Oct 2018

I have tested this item successfully on a1a738b

I got all cassiopeia css files back but
I had to remove line 27 in /build/build-modules-js/update.js to allow
npm install
to work.

fsExtra.copySync(Path.join(rootPath, 'libraries/vendor/maximebf/debugbar/src/DebugBar/Resources'), Path.join(rootPath, 'media/vendor/debugbar'));

Not sure if it is the right way though.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22831.

avatar ghazal ghazal - test_item - 27 Oct 2018 - Tested successfully
avatar bembelimen
bembelimen - comment - 27 Oct 2018

I have tested this item successfully on a1a738b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22831.

avatar bembelimen bembelimen - test_item - 27 Oct 2018 - Tested successfully
avatar infograf768 infograf768 - change - 27 Oct 2018
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 27 Oct 2018
avatar infograf768
infograf768 - comment - 27 Oct 2018
avatar laoneo laoneo - close - 27 Oct 2018
avatar laoneo laoneo - merge - 27 Oct 2018
avatar laoneo laoneo - change - 27 Oct 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-27 15:27:37
Closed_By laoneo
Labels Added: ?
avatar Chacapamac
Chacapamac - comment - 29 Oct 2018

How do I know when & where I apply the fix or update?

avatar ghazal
ghazal - comment - 29 Oct 2018

Check this:
J4.x:Setting Up Your Local Environment - Joomla! Documentation
https://docs.joomla.org/Special:MyLanguage/J4.x:Setting_Up_Your_Local_Environment
and this:
JavaScript Tests for Joomla4 - Joomla! Documentation
https://docs.joomla.org/JavaScript_Tests_for_Joomla4

Even though, in my opinion, these tuts should be revised.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Oct 2018

Even though, in my opinion, these tuts should be revised.

"Docs" is a Wiki, so anyone can contribute, revise ;-)

avatar ghazal
ghazal - comment - 30 Oct 2018

Yes. Indeed.
But my knowledge of CLI, NPM, Composer, etc ... is barely sufficient to get me through the procedure. I have more questions than answers.

avatar wilsonge
wilsonge - comment - 30 Oct 2018

So what specific question do you have :) here to help!

Add a Comment

Login with GitHub to post a comment