User tests: Successful: Unsuccessful:
As suggested in #22700 this skips generating links for the action log messages since they aren't going to be used in most export formats anyway (and in fact the CSV export helper has a strip_tags()
call). This offers a memory boost by not having to go through the router after the memory issues identified in #22807.
A Blackfire graph can be reviewed at https://blackfire.io/profiles/compare/4f46ce4e-d86a-4496-b857-146bb34f7956/graph - note that the increased number of Joomla\CMS\Language\Text::_()
and ActionlogsHelper::getHumanReadableLogMessage()
calls is actually because more log messages are being included in my exports; the first request in the comparison is actually reaching my 90 second timeout (after 58,700 rows while with this patch I'm now over 102,000 rows before the timeout is reached)
With the patch applied, the action logs CSV file should still be exported. If you're profiling the request, you should note a decrease in memory use, and depending on how large of an export you're working with probably an increase in row count.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration |
Labels |
Added:
?
|
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-28 18:32:48 |
Closed_By | ⇒ | mbabker | |
Labels |
Added:
?
|
I have tested this item✅ successfully on 56360ec
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22815.