Joomla! Issue Tracker | Joomla! CMS #2281 - [stools][fix] Various fixes

Closed
21 Oct 2013
Medium
Build: master
# 2281
Diff
phproberto:stools-fixes
Foreign ID 32361

Success

Success The Travis CI build passed Details

User tests: Successful: Unsuccessful:

phproberto
18 Oct 2013

Tracker issue:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32361&start=0

This pull request fixes:

Remove unused $langs in layouts.
Missing translations in menus management ordering field
Ordering by associations should not be shown when associations are not enabled
In banner clients you cannot filter by unpublished + monthly. it doesn't filter by status
Fix mobile device views
Filter by content languages available,, not by languages available
Pagination error for custom limit
Menu items not ordered by ordering / sortable not working

I also improved search tools with:

Include minified versions of the search tools jQuery plugin
Load search tools directly from an JHtml library instead of a layout
Now search tools allows you to avoid loading core jQuery
Now the clear button doesn't remove the ordering & limit options (I added a clearListOptions option to be able to enable disable it)
I verified that moving 10 lines of code from the layout to the view column ordering works without loading the layouts. I didn't move all the code to views because it will be a lot of duplicated code but it's an option for devs now if they don't want to use search tools.
Added the option to show/hide ordering+limit fields with a button like the "Search tools" one.

phproberto - open - 18 Oct 2013

infograf768 - comment - 19 Oct 2013

Options still disapear when filtering by a specific category in article manager

Big bug: language filter filters by language installed, NOT by Content language as it should

type in filters_xxx.xml should be
type="contentlanguage"
not
type="language"

phproberto - comment - 19 Oct 2013

@infograf768 options dissappear is not related with this patch (you can check it also happens in contacts) but with the permissions checking done in:

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30417
Pull request:
#2049

Apparently that mixed content helpers into one single helper to remove duplicated code.

The button is enabled in the view.html.php when this if statement is true:

        if ($canDo->get('core.admin'))
        {
            JToolbarHelper::preferences('com_content');
        }

As you see the user requries rights for core.admin. The permissions are loaded with:

$canDo = JHelperContent::getActions($this->state->get('filter.category_id'), 0, 'com_content');

when you filter by category the call is like:

$canDo = JHelperContent::getActions(20, 0, 'com_content');

Internally JHelperContent detects that it has to check in the com_content access.xml inside section category:

section: category | asset: com_content.category.20

But the core.admin does not exist in the category section of access.xml:

    <section name="category">
        <action name="core.create" title="JACTION_CREATE" description="COM_CATEGORIES_ACCESS_CREATE_DESC" />
        <action name="core.delete" title="JACTION_DELETE" description="COM_CATEGORIES_ACCESS_DELETE_DESC" />
        <action name="core.edit" title="JACTION_EDIT" description="COM_CATEGORIES_ACCESS_EDIT_DESC" />
        <action name="core.edit.state" title="JACTION_EDITSTATE" description="COM_CATEGORIES_ACCESS_EDITSTATE_DESC" />
        <action name="core.edit.own" title="JACTION_EDITOWN" description="COM_CATEGORIES_ACCESS_EDITOWN_DESC" />
    </section>