[#22808] - Only get config and user from factory when needed in `JHtml::date()`
- Fixed in Code Base
- 24 Oct 2018
- Medium
- Build: staging
- # 22808
- Diff
- mbabker:jhtml-date-only-get-objects-when-needed
User tests: Successful: Unsuccessful:
Partial Pull Request for Issue #22779
Summary of Changes
Calls to Joomla\CMS\Factory::getUser() with no arguments end up in a call to Joomla\CMS\Session\Session::get() so this isn't a highly performant method call and should only happen when needed. In Joomla\CMS\HTML\HTMLHelper::date(), it is only needed in one of the four conditions, so there is no need to always call this method. Likewise, Joomla\CMS\Factory::getConfig() only needs to be called in one of the four conditions. So, stop arbitrarily calling these two methods on every call to Joomla\CMS\HTML\HTMLHelper::date() and only call them when actually needed.
Testing Instructions
With the patch applied, date/time strings are still correctly localized.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22808.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-24 11:54:14 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item✅ successfully on ef701c2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22808.