Joommla 4.0-dev @ 9d3acfd
Login to admin -> Settings
see
Click Settings or text filters - expect to be taken to the right tab in config page
Taken to config page but the tab is not selected
Disappointed as I spent a LOT of time working with tabs in Joomla 3.
Labels |
Added:
?
|
Actually @rdeutz needs to provide a drone instance for that repo due to the sauce labs credentials (need to be passed as env variables). Similar to joomla/test-javascript#10
@PhilETaylor actually this is ok as the system settings page uses still the old jQuery Bootcrap code. Once converted to the new joomla-ui the functionality will be restored
this is ok
Meaning that its broken, and people should ignore that its broken?, not that it "is ok"
@PhilETaylor here is the default.php with the new tabs:
<div class="col-md-10">
<joomla-tab view="tabs" oriendation="horizontal" id="config-document">
<section id="page-site" name="<?php echo Text::_('JSITE'); ?>">
<div class="row">
<div class="col-lg-12 col-xl-6">
<?php echo $this->loadTemplate('site'); ?>
<?php echo $this->loadTemplate('metadata'); ?>
</div>
<div class="col-lg-12 col-xl-6">
<?php echo $this->loadTemplate('seo'); ?>
<?php echo $this->loadTemplate('cookie'); ?>
</div>
</div>
</section>
<section id="page-system" name="<?php echo Text::_('COM_CONFIG_SYSTEM'); ?>">
<div class="row">
<div class="col-md-12">
<?php echo $this->loadTemplate('system'); ?>
<?php echo $this->loadTemplate('debug'); ?>
<?php echo $this->loadTemplate('cache'); ?>
<?php echo $this->loadTemplate('session'); ?>
</div>
</div>
</section>
<section id="page-server" name="<?php echo Text::_('COM_CONFIG_SERVER'); ?>">
<div class="row">
<div class="col-lg-12 col-xl-6">
<?php echo $this->loadTemplate('server'); ?>
<?php echo $this->loadTemplate('locale'); ?>
<?php echo $this->loadTemplate('ftp'); ?>
<?php echo $this->loadTemplate('proxy'); ?>
</div>
<div class="col-lg-12 col-xl-6">
<?php echo $this->loadTemplate('database'); ?>
<?php echo $this->loadTemplate('mail'); ?>
</div>
</div>
</section>
<section id="page-filters" name="<?php echo Text::_('COM_CONFIG_TEXT_FILTERS'); ?>">
<div class="row">
<div class="col-md-12">
<?php echo $this->loadTemplate('filters'); ?>
</div>
</div>
</section>
<?php if ($this->ftp) : ?>
<section id="page-ftp" name="<?php echo Text::_('COM_CONFIG_FTP_SETTINGS'); ?>">
<div class="col-md-12">
<?php echo $this->loadTemplate('ftplogin'); ?>
</div>
</section>
<?php endif; ?>
<section id="page-permissions" name="<?php echo Text::_('COM_CONFIG_PERMISSIONS'); ?>">
<div class="row">
<?php echo $this->loadTemplate('permissions'); ?>
</div>
</section>
<input type="hidden" name="task" value="">
<?php echo HTMLHelper::_('form.token'); ?>
</joomla-tab>
</div>
Enjoy
Meaning that its broken, and people should ignore that its broken?, not that it "is ok"
Meaning that someone needs to drop the old script and markup and move that page to the new one. The code is right above.
OK means that is expected that the old tab state script doesn't work anymore, it's deprecated and once all the tabs converted it will be deleted
Labels |
Added:
J4 Issue
|
@dgrammatiko could you please specify the path to the above default.php file?
Thanks @dgrammatiko
@dgrammatiko when I used the above code in https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_config/tmpl/application/default.php on clicking on Setting
or Text Filters
the Text Filters
tab is the one that remains activated regardless of what is clicked.
Clan your browser cache
@dgrammatiko I've cleaned browser cache, but what I have noticed is that after clicking on any tab in config page when I go back to admin->System and on clicking Settings
or Text Filters
the tab which I had previously clicked is the one that remains activated, regardless of what is being clicked on.
@hardik-codes are you actually loading the tabs custom element? Did you remove the old scripts from the page?
The code above is just the html changes, there are also the scripts that need to be loaded there
@dgrammatiko could you please help me remove those.
@hardik-codes there you go: #23780
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-06 15:44:29 |
Closed_By | ⇒ | joomla-cms-bot |
Closed_Date | 2019-02-06 15:44:29 | ⇒ | 2019-02-06 15:44:34 |
Closed_By | joomla-cms-bot | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/22793
This probably comes from this joomla-projects/custom-elements#106
That repo although it has tests the tests don't run as travis is not passing the environment variables for sauce labs anymore...
In sort people need to run the tests locally before committing any code.