Feeling Lucky
?
[#22786] - [4.0]Fix loading language files from module extension folder
- Fixed in Code Base
- 24 Oct 2018
- Medium
- Build: 4.0-dev
- # 22786
- Diff
- joeforjoomla:4.0-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #22768 .
Summary of Changes
dirname(..) is not referring to the correct file/path anymore, that is causing the loading of modules language files failing.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
laoneo
- comment
- 24 Oct 2018
I think too that the extra call of dirname can be removed.
infograf768
- comment
- 24 Oct 2018
@joeforjoomla
can you modify your PR ?
| Labels |
Added:
?
|
||
joeforjoomla
- comment
- 24 Oct 2018
I modified the PR, basically removing the extra dirname works the same
infograf768
- comment
- 24 Oct 2018
I have tested this item
Can now be merged on review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22786.
laoneo
- comment
- 24 Oct 2018
Thanks!
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-24 10:05:23 |
| Closed_By | ⇒ | laoneo |
Why do we use
dirname?If I use
$extensionLanguageDirectory = JPATH_BASE . '/modules/' . $this->module->module;it works fine.
@laoneo ?