[#22774] - confirm request remove ugly legend
- Closed
- 27 Apr 2019
- Medium
- Build: staging
- # 22774
- Diff
- alikon:patch-118
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
from <legend> to <p>
Testing Instructions
confirm a privacy request
Expected result
Actual result
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End |
I don't see the "Actual result" in J3.9.2 anymore. I see a text formatted compatibly with the text around. I see "Expected result" with no patch applied.
I agree that no emphasis is needed in this situation (notice on sent e-mail). If emphasis is needed, a Message (of type message or notice) should be used.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22774.
on staging I still see that
| Labels |
Added:
?
|
||
OK, I confirm the stated: The text is larger and inconsistent with other messages.
(My personal ignorance and mistake.)
Mind the similarity with the "verification code"
Here is the message with "confirmation token"
In principle, it is the same process (request and confirm by a code/token), and should the messages use the same wording and terminology, shouldn't they?
I would also prefer to use message as in "requesting a forgotten username"
but of type Notice (unfinished action).
I have tested this item
J3.9.2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22774.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22774.
| Title |
|
||||||
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Labels |
Added:
?
|
||
This should not be RTC in its current form
A fieldset must have a legend. If you remove it here then we will only have to put it back in J4 where we take a11y seriously.
That does not mean that the wall of text has to remain as the legend.
That also does not mean that the wall of text cannot remain as a legend and be styled as a paragraph.
As it is this PR is just wrong, sorry
| Status | Ready to Commit | ⇒ | Pending |
Status back on Pending.
I set RTC cause i thought i have missed the 2 successfully tests.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-27 08:11:28 |
| Closed_By | ⇒ | alikon | |
| Labels |
Removed:
J3 Issue
?
|
||
See arguments for and against in #22765
Also, as reported here #22630