I thought that the description of a fieldset was a legend

I thought that the description of a fieldset was a legend

Not exactly. It doesn't include the description, only the name of the fieldset is shown in the legend. This is different to how the profile view behaves.

I thought that the description of a fieldset was a legend

I think we've got mixed uses in core (i.e. I know in com_privacy we're using a description for the <legend> and one of Phil's issues highlights why that's not so good). Since our fieldsets support a label attribute that would be the best thing to put in the <legend> element and let the description be a paragraph or div or whatever block element.

I thought that the description of a fieldset was a legend

I think we've got mixed uses in core (i.e. I know in com_privacy we're using a description for the <legend> and one of Phil's issues highlights why that's not so good). Since our fieldsets support a label attribute that would be the best thing to put in the <legend> element and let the description be a paragraph or div or whatever block element.

That is indeed how the profile view handles it.

@IsaacWG I meant that the purpose of the legend tag in html is to show a description of the fieldset. So I would expect that if I create a description for a fieldset it will be displayed inside a legend tag

Remember the legend has semantic meaning

@IsaacWG I meant that the purpose of the legend tag in html is to show a description of the fieldset. So I would expect that if I create a description for a fieldset it will be displayed inside a legend tag

Remember the legend has semantic meaning

Gotcha. In that case, should the description be placed in the legend tag instead of the label in other places as well? If so, what will happen to the label text?

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/legend

Between that and W3C specs what I'm taking is that for this form definition:

<form>
    <fieldset label="Short Summary" description="Longer blurb about this fieldset"/>
</form>

The label should be what we put in the <legend> and if there's a longer description it should be a block element inside the fieldset. Otherwise you end up with #22630 where the legend ends up being a big blob of text.

22630 is just a CSS issue.

So you're saying that is the semantically correct use of a <legend> tag? Because that really does not feel right to me at all.

I think I'd have to agree with @mbabker on this, at least if we're following the W3C specs at https://www.w3.org/TR/html50/forms.html#the-legend-element:

The legend element represents a caption for the rest of the contents of the legend element's parent fieldset element, if any.

A caption is defined as

a title or brief explanation appended to an article, illustration, cartoon, or poster.

In my humble opinion this seems to fit much better with the label than the description, since descriptions can get quite long.

• Shouldn't we use a <div> instead of a <p> to avoid invalid HTML if description contains paragraphs etc.
• Why do we need to escape() (html_entities) the description?

* Shouldn't we use a `<div>` instead of a `<p>` to avoid invalid HTML if description contains paragraphs etc.

* Why do we need to escape() (html_entities) the description?

There "shouldn't" be any HTML in the descriptions and therefore no <p> tags, or at least I can't think of any reason why there should be. Escaping the description helps prevent XSS attacks in case the description is ever set by user input or another untrusted source.

There "shouldn't" be any HTML in the descriptions and therefore no

tags, or at least I can't think of any reason why there should be

So, it's forbidden to add several paragraphs or line breaks or ... in a form description? Sounds strange for me.

in case the description is ever set by user input or another untrusted source.

In this case here that's a little bit paranoid, I think. Who can change the description?

I see absolute no reason NOT to use a <div> - container plus CSS class here.

Please keep in mind everybody, that the point of this pull request was to make the registration view show the fieldset descriptions in the same way that the profile view does. If we need to change how the registration view behaves on this, we should change the profile view as well to keep things consistent.

In this case here that's a little bit paranoid, I think. Who can change the description?

Perhaps I am being a bit paranoid. Yes, almost always it's going to be an administrator setting the descriptions, and I suppose if say a plugin is adding its own fieldsets and setting the descriptions it should be up to that plugin to escape any user provided data.

In any case, the profile view should be changed as well to allow HTML if we let the registration view allow it.

I have tested this item ✅ successfully on d7d44c0

We reproduced the testing instructions and the description appeared as expected

I have tested this item ✅ successfully on d7d44c0

RTC

Because this is a new feature we can't merge in to J3.9, please create a new pull request for Joomla! 4.0