You shouldnt be getting JUST "Error updating COM_INSTALLER_TYPE_TYPE_".

The code at line 466 shouldnt be getting the type and adding it to the
string
$package['type']

On 22 October 2018 at 13:47, Jonathan Brain notifications@github.com
wrote:

When attempting to update an extension where the update server returns an
invalid package get the error message "Error updating
COM_INSTALLER_TYPE_TYPE_".

This does not provide any meaningful / helpful information.

When JInstallerHelper::unpack(...) on line 445 of update.php returns an
invalid package a more meaningfull message should be returned. Such as...

// Unpack the downloaded package file
$package = JInstallerHelper::unpack($tmp_dest . '/' . $p_file);
if (!isset($package['type']))
{
$msg = JText::Sprintf('COM_INSTALLER_MSG_UPDATE_INVALID_PKG', $p_file));
$app->enqueueMessage($msg);
return false;
}

The language file text should read something like:
COM_INSTALLER_MSG_UPDATE_INVALID_PKG="Invalid package file: '%s'"

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#22762, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8UTHh3wtOluPuZOj_jvDnHoSEthlks5unb5QgaJpZM4XzUhD
.

--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

Created pull request with code changes for this.

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/22762

Closing per PR #22763