New installer files should be provided when changing data. old installers should NOT be changed.
Copyright years is updated within OLD installer file.
any system, this is about installer file contents.
I understand doing sed
replace inline or simple "Find and replace in the project" is easy and fast. But this is not how data consistency is enforced.
This also makes very hard to realize what has changed in the update and if it is important or not because of a lot of copyrights changes within the files.
This also makes very hard to realize what has changed in the update and if it is important or not because of a lot of copyrights changes within the files.
Just to give you some heads up. In the release note, you see if the update is important or not. If it's called a security update, it is important - no excuses. If it is a regular update, you can delay the update a bit, but it still absolutely should be installed.
As long as you don't do any core hacks (which you must not do anyway), it shouldn't matter to you what changes were done in the update in detail. You're going to apply the update sooner or later anyway.
So imho, I see no reason to change our past behavior of changing the copyright in all files (SQL files included). If there are other reasons to not change the copyright date, we can evaluate it for sure, but this reason doesn't sound like a good enough argument to me.
@brianteeman :
If the process is bad (and here, it is), and there's a way to improve it in the future, it SHOULD be improved. Especially when it saves time.
@Bakual
Once the update is not about security BUT it changes the way our core business functionality works (i.e - just stupid example - form handling), then for the business/client it is also important to look into how that thing was changed without browsing through thousands of files that just changed copyright notice along with the rest of the update. Security updates are another type of the required code updates.
If you're talking about copyright statements in the extension manifest caches, honestly those caches shouldn't be in the SQL files anyway as they're automatically (re-)generated at initial install or update. So that's a non-issue.
If you're talking real structure or "critical" core data changes, agree in full.
Even if it was changed now it wont help you
Can you elaborate on this? Because right now what you're saying doesn't make sense (at least not without context)
You should be updating joomla through the joomlaupdate component
Are you sure update component doesn't update the old files copyright? (making Joomla package files and server files inconsistent, so doesn't sound like a good thing)
Labels |
Added:
J3 Issue
|
Status | New | ⇒ | Discussion |
@HLeithner can you please comment for J3?
Status | Discussion | ⇒ | Information Required |
Category | ⇒ | com_joomlaupdate |
Just another reason to change this - save time:
example:
I would like to correct my comments above. I was under the impression that OLD update sql files would not be looked at again after they had been used. Seems that there is a bug that instead of being fixed people have change those old update files and they are being looked at
@HLeithner do we have any update to provide here or is the determination that it is a legal decision for this issue?
Since it's a legal thing I will contact Hugh Douglas-Smith about this.
@HLeithner I guess nothing is going to happen here now and this should be closed. Not my call though
Status | Information Required | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-23 21:38:18 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
No Code Attached Yet
Removed: ? |
Since we no longer update old files and set all copyright dates to the (hopefully) original date this issue can be closed because it's solved. @brianteeman thanks for pointing me to this pr again.
Well we dont update old files for copyright but the sql update files are not immutable as I constantly debate with @richard67
Not sure how a change would help you now.