? ? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
20 Oct 2018

Pull Request for Issue #22629

Summary of Changes

  • Standardizes the timezone used for timestamps in the actionlog export to UTC
  • Standardizes the timestamp to always use the Y-m-d H:i:s T format versus one that is translated so the format does not change based on who exports the data
  • As hinted at above, the timezone is printed in the timestamp now

Testing Instructions

  • Apply patch
  • Export action logs
  • Check the date column

Expected result

Timestamp is clear as it relates to timezones and consistently formatted

Actual result

Timestamp is ambiguous and can be formatted differently based on the admin who exports the logs

avatar mbabker mbabker - open - 20 Oct 2018
avatar mbabker mbabker - change - 20 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Oct 2018
Category Administration
avatar PhilETaylor
PhilETaylor - comment - 20 Oct 2018

GMT !== UTC

can the GMT be changed to UTC in the file name too ?

avatar mbabker mbabker - change - 20 Oct 2018
Labels Added: ?
avatar mbabker
mbabker - comment - 20 Oct 2018

can the GMT be changed to UTC in the file name too ?

Done.

avatar PhilETaylor
PhilETaylor - comment - 20 Oct 2018

I have tested this item successfully on a55bee7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22751.

avatar PhilETaylor PhilETaylor - test_item - 20 Oct 2018 - Tested successfully
avatar alikon
alikon - comment - 21 Oct 2018

I have tested this item successfully on a55bee7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22751.

avatar alikon alikon - test_item - 21 Oct 2018 - Tested successfully
avatar Fedik
Fedik - comment - 21 Oct 2018

use the Y-m-d H:i:s T

would not be better to use one of standard format, ISOxxx/RFCxxx/atom ?
if talk about standards

avatar PhilETaylor
PhilETaylor - comment - 21 Oct 2018

I think Y-m-d H:i:s T is more user-friendly than a standard ISO8601 format which would make the date/time

2018-10-21T12:22:03+00:00

Plus (and I generalize here, sorry USA) most Americans would know their timezone, but not its offset to UTC/GMT.

Personally I don't think we even need the seconds in the file name but as a developer seeing H:i without s just looks odd :)

avatar Fedik
Fedik - comment - 21 Oct 2018

okay, I just asked :)

avatar Quy Quy - change - 21 Oct 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 21 Oct 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22751.

avatar mbabker mbabker - change - 23 Oct 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-23 19:46:01
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 23 Oct 2018
avatar mbabker mbabker - merge - 23 Oct 2018

Add a Comment

Login with GitHub to post a comment