? Success

User tests: Successful: Unsuccessful:

avatar elkuku
elkuku
17 Oct 2013

The pluralization of the visitors counter in the backend mod status is wrong.

Before

@BUG mod_status before

Note the plural form for 1 Visitors and 1 Admins.

After

mod_status7


The original proposal was:
mod_status fixed
the text had been moved to a tooltip.

avatar elkuku elkuku - open - 17 Oct 2013
avatar brianteeman
brianteeman - comment - 17 Oct 2013

I agree that the plural is wrong but moving the description to a tooltip makes the 2 icons identical and meaningless

avatar elkuku
elkuku - comment - 17 Oct 2013

How about this approach:
mod_status2

Note that the underlying issue is passing a HTML string to JText::plural() instead of an integer.....

So to make it work using the bootstrap badges, you would have to include the HTML markup in the language files.

avatar brianteeman
brianteeman - comment - 17 Oct 2013

Sorry still doesn't look right to me. Personal opinion of course

avatar elkuku
elkuku - comment - 17 Oct 2013

While I somewhat agree.... any suggestion ? :wink:

avatar betweenbrain
betweenbrain - comment - 17 Oct 2013

Is it not possible to fix the pluralization using the original (https://f.cloud.github.com/assets/33978/1353270/ca86b2fc-3742-11e3-9a1d-39379776751c.png) layout?

avatar elkuku
elkuku - comment - 18 Oct 2013

OK, so now it looks like this
mod_status7

There is however a slight B/C issue, requiring an adjustment of language files:
mod_status6

Also, I'm not sure about RTL languages.

There is definitely no easy fix for this, preserving the current layout.

avatar elkuku
elkuku - comment - 19 Oct 2013

For reference (or debugging), the current arabic version looks like this:
mod_status9

This has already applied the CSS patch from @infograf768

أي شكاوى؟

avatar infograf768 infograf768 - close - 20 Oct 2013
avatar elkuku elkuku - head_ref_deleted - 20 Oct 2013
avatar elkuku
elkuku - comment - 21 Oct 2013

Another idea we are trying in JTracker:
jtracker-debug-toolbar
The orange "2" means, that there are 2 untranslated language strings :wink:

avatar garyamort garyamort - reference | - 2 Dec 13

Add a Comment

Login with GitHub to post a comment