? ? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
20 Oct 2018

Pull Request for Issue #22708

Summary of Changes

  • Adds a privacy plugin to export user data from the #__privacy_consents table
    • This does not add the remove logic that would close #22720
  • Enables the "Privacy - Action Logs" plugin by default, there is no reason it shouldn't be

Testing Instructions

  • Apply patch, ensure new plugin is installed and enabled, log a consent for the user who you will eventually be exporting data for, create an export request for that user, export their data, check the XML includes the consents

Expected result

Consents included in export

Actual result

Consents not included in export

Documentation Changes Required

N/A, we don't have each individual plugin documented

Stuck Between A Rock And A Hard Place

This is introducing a new plugin well after feature and language freeze for 3.9. So we have a few options:

  • Ship it in 3.10 (SemVer)
  • Ship it in 3.9.1 (not SemVer but should be in core anyway)
  • Ship it in 3.9.0 without translation requirement
avatar mbabker mbabker - open - 20 Oct 2018
avatar mbabker mbabker - change - 20 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Oct 2018
Category SQL Administration com_admin Postgresql MS SQL Language & Strings Installation Libraries Front End Plugins
avatar alikon
alikon - comment - 21 Oct 2018

Ship it in 3.9.0 without translation requirement

avatar alikon
alikon - comment - 21 Oct 2018

I have tested this item successfully on d0c9909


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22749.

avatar alikon alikon - test_item - 21 Oct 2018 - Tested successfully
avatar alikon
alikon - comment - 21 Oct 2018

guess we should add a similar one for #__privacy_requests table ?

avatar infograf768
infograf768 - comment - 21 Oct 2018

Ship it in 3.9.0 without translation requirement

If merged, it will anyway be ported to crowdin and TTs will have to translate.
As we also have #22752 , this means that TTs would have to touch their packs in any case.

That's only 3 strings.

avatar mbabker mbabker - change - 24 Oct 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-24 01:15:23
Closed_By mbabker
Labels Added: ? ?
avatar mbabker mbabker - close - 24 Oct 2018
avatar mbabker mbabker - merge - 24 Oct 2018

Add a Comment

Login with GitHub to post a comment