User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings Front End Plugins |
Labels |
Added:
?
?
|
Title |
|
I have tested this item
Class 'Factory' not found
/administrator/components/com_actionlogs/models/actionlogs.php:300
Class 'Factory' not found
/administrator/components/com_actionlogs/models/actionlogs.php:323
I have tested this item
Class 'Factory' not found
/administrator/components/com_actionlogs/models/actionlogs.php:300
Class 'Factory' not found
/administrator/components/com_actionlogs/models/actionlogs.php:323
I have tested this item
Does the export language need to reflect if EVERYTHING was exported, or if just a few rows were exported?
What happens when a few rows are deleted? nothing? if we are rewriting history then that should be logged too right?
the Factory::getApplication()->triggerEvent('onAfterLogPurge', array());
happens
https://github.com/joomla/joomla-cms/pull/22740/files#diff-6d4ae54d455c6ccba7a75cc85b8bca19R301
https://github.com/joomla/joomla-cms/pull/22740/files#diff-6d4ae54d455c6ccba7a75cc85b8bca19R324
so no, no different messages are logged if you delete some or all
so in that case saying
User {username} purged the action log
is actually factually incorrect and the language/terminology used needs to be changed - maybe something like
User {username} purged one or more rows from the action log
feel free to submit the correct string, pr is open
english is not my best friend ;)
As the only codeowner for language strings, the ultimate decision is with @brianteeman - he has already approved your language string even though it is factually incorrect.
I suggest he writes the factually correct sentence using his English skills.
I have tested this item
I have tested this successfully on Joomla! 3.9.2.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-07 17:46:31 |
Closed_By | ⇒ | alikon |
Status | Closed | ⇒ | New |
Closed_Date | 2019-03-07 17:46:31 | ⇒ | |
Closed_By | alikon | ⇒ | |
Labels |
Removed:
?
|
Status | New | ⇒ | Pending |
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-07 19:32:04 |
Closed_By | ⇒ | HLeithner |
thx
Does the export language need to reflect if EVERYTHING was exported, or if just a few rows were exported?