? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
20 Oct 2018

Pull Request for Issue #22695.

Summary of Changes

  • row/event is inserted/triggred after the purge
  • row/event is inserted/triggred after the export

Testing Instructions

Export/Purge the action logs
see #22695

Documentation Changes Required

avatar alikon alikon - open - 20 Oct 2018
avatar alikon alikon - change - 20 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Oct 2018
Category Administration Language & Strings Front End Plugins
avatar alikon alikon - change - 20 Oct 2018
Labels Added: ? ?
avatar alikon alikon - change - 20 Oct 2018
The description was changed
avatar alikon alikon - edited - 20 Oct 2018
avatar alikon alikon - change - 20 Oct 2018
The description was changed
avatar alikon alikon - edited - 20 Oct 2018
avatar alikon alikon - change - 20 Oct 2018
Title
[com_actionlogs] - log actionlog purge
[com_actionlogs] - log actionlog purge/export
avatar alikon alikon - edited - 20 Oct 2018
avatar PhilETaylor
PhilETaylor - comment - 20 Oct 2018

Does the export language need to reflect if EVERYTHING was exported, or if just a few rows were exported?

avatar ReLater
ReLater - comment - 6 Nov 2018

I have tested this item 🔴 unsuccessfully on a4b8b28

Class 'Factory' not found
/administrator/components/com_actionlogs/models/actionlogs.php:300

Class 'Factory' not found
/administrator/components/com_actionlogs/models/actionlogs.php:323


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22740.

avatar ReLater
ReLater - comment - 6 Nov 2018

I have tested this item 🔴 unsuccessfully on a4b8b28

Class 'Factory' not found
/administrator/components/com_actionlogs/models/actionlogs.php:300

Class 'Factory' not found
/administrator/components/com_actionlogs/models/actionlogs.php:323


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22740.

avatar ReLater ReLater - test_item - 6 Nov 2018 - Tested unsuccessfully
avatar alikon
alikon - comment - 8 Nov 2018

@ReLater please retest

avatar ReLater
ReLater - comment - 8 Nov 2018

I have tested this item ✅ successfully on 7f60480


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22740.

avatar ReLater ReLater - test_item - 8 Nov 2018 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 8 Nov 2018

Does the export language need to reflect if EVERYTHING was exported, or if just a few rows were exported?

What happens when a few rows are deleted? nothing? if we are rewriting history then that should be logged too right?

avatar alikon
alikon - comment - 8 Nov 2018

the Factory::getApplication()->triggerEvent('onAfterLogPurge', array());

happens
😄

https://github.com/joomla/joomla-cms/pull/22740/files#diff-6d4ae54d455c6ccba7a75cc85b8bca19R301
https://github.com/joomla/joomla-cms/pull/22740/files#diff-6d4ae54d455c6ccba7a75cc85b8bca19R324

so no, no different messages are logged if you delete some or all

avatar PhilETaylor
PhilETaylor - comment - 8 Nov 2018

so in that case saying

User {username} purged the action log

is actually factually incorrect and the language/terminology used needs to be changed - maybe something like

User {username} purged one or more rows from the action log

avatar alikon
alikon - comment - 8 Nov 2018

feel free to submit the correct string, pr is open
english is not my best friend ;)

avatar PhilETaylor
PhilETaylor - comment - 8 Nov 2018

As the only codeowner for language strings, the ultimate decision is with @brianteeman - he has already approved your language string even though it is factually incorrect.

I suggest he writes the factually correct sentence using his English skills.

a9da4b8 20 Jan 2019 avatar alikon ..
avatar tecpromotion
tecpromotion - comment - 31 Jan 2019

I have tested this item ✅ successfully on a9da4b8

I have tested this successfully on Joomla! 3.9.2.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22740.

avatar tecpromotion tecpromotion - test_item - 31 Jan 2019 - Tested successfully
avatar viocassel
viocassel - comment - 3 Feb 2019

I have tested this item ✅ successfully on a9da4b8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22740.

avatar viocassel viocassel - test_item - 3 Feb 2019 - Tested successfully
avatar Quy Quy - change - 3 Feb 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 3 Feb 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22740.

avatar alikon alikon - change - 10 Feb 2019
Labels Added: ?
avatar alikon alikon - change - 7 Mar 2019
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2019-03-07 17:46:31
Closed_By alikon
avatar alikon alikon - close - 7 Mar 2019
avatar alikon alikon - change - 7 Mar 2019
Status Closed New
Closed_Date 2019-03-07 17:46:31
Closed_By alikon
Labels Removed: ?
avatar alikon alikon - change - 7 Mar 2019
Status New Pending
avatar alikon alikon - reopen - 7 Mar 2019
avatar HLeithner HLeithner - change - 7 Mar 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-03-07 19:32:04
Closed_By HLeithner
avatar HLeithner HLeithner - close - 7 Mar 2019
avatar HLeithner HLeithner - merge - 7 Mar 2019
avatar HLeithner
HLeithner - comment - 7 Mar 2019

thx

Add a Comment

Login with GitHub to post a comment