? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
19 Oct 2018

Pull Request for an Issue raised at the German forum: https://forum.joomla.de/thread/6488-passwort-zur%C3%BCck-setzen-meldung-falsch-oder-vorgang-falsch/?postID=45036 (german)

Summary of Changes

This now adds a note that should make the use of the token more clear. But I would like to hear an native speakers opinion too. Maybe this can be even more improved? cc @brianteeman

Testing Instructions

  • create an non-superuser
  • request a new PW from the frontend
  • click the link in the mail

Expected result

The message makes clear that there is not send another mail with a token when the token is filled just the usernamen needs to be added.

Actual result

image

Documentation Changes Required

none

avatar zero-24 zero-24 - open - 19 Oct 2018
avatar zero-24 zero-24 - change - 19 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Oct 2018
Category Language & Strings
avatar brianteeman
brianteeman - comment - 19 Oct 2018

The problem is not really with the string - in my opinion
The problem for me is that I end up with two screens open in my browser
forgot-password?layout=confirm
and
forgot-password?layout=confirm&token=
and we really should have seperate strings for each

An email has been sent to your email address. The email has a verification code, please paste the verification code in the field below and enter your username to prove that you are the owner of this account.

Please enter your username to prove that you are the owner of this account.

avatar zero-24
zero-24 - comment - 19 Oct 2018

Ok. my problem is that this would mean we need to break the view https://github.com/joomla/joomla-cms/blob/staging/components/com_users/views/reset/tmpl/confirm.php as the language string comes from this line https://github.com/joomla/joomla-cms/blob/staging/components/com_users/models/forms/reset_confirm.xml#L3.

That is the reason i suggested a language string change over an view change.

avatar brianteeman
brianteeman - comment - 19 Oct 2018

Conditional string?

avatar zero-24
zero-24 - comment - 19 Oct 2018

Yes this is possible but this would still mean to modify the view php code which I would like to avoid.

avatar brianteeman
brianteeman - comment - 19 Oct 2018

If you dont have two strings then one of the views will always read wrong - to me at least. Others may disagree

avatar mbabker
mbabker - comment - 19 Oct 2018

The only difference, and the same exists with the privacy confirmation stuff, is basically whether the token field was prefilled because you have a token= value in the query string. It's not enough to warrant two separate views, and IMO it's flaky behavior at best to have a different string based on whether the token has a value from the request (because there's no guarantee it's actually the right token either, stuff ?token=abcd in on the URL and see what happens).

Two strings would be the way to go if you change anything.

avatar zero-24
zero-24 - comment - 28 Oct 2018

Ok closing here than. Thanks!

avatar zero-24 zero-24 - close - 28 Oct 2018
avatar zero-24 zero-24 - change - 28 Oct 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-10-28 12:56:22
Closed_By zero-24
Labels Added: ? ?

Add a Comment

Login with GitHub to post a comment