? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
18 Oct 2018

@joomla/security

Add missing token check for CSRF to purge action

Good, and important catch!

avatar PhilETaylor PhilETaylor - open - 18 Oct 2018
avatar PhilETaylor PhilETaylor - change - 18 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Oct 2018
Category Administration
avatar PhilETaylor PhilETaylor - change - 18 Oct 2018
Labels Added: ?
avatar PhilETaylor PhilETaylor - change - 18 Oct 2018
Title
[com_actionlogs][Security] Check for token before allowing purge
[com_actionlogs][Security][RELEASE BLOCKER] Check for token before allowing purge
avatar PhilETaylor PhilETaylor - edited - 18 Oct 2018
avatar PhilETaylor
PhilETaylor - comment - 19 Oct 2018

I think you are seeing things! This was a direct copy and paste in github in the browser.. I see no tabs?!?!

——
Sent from my iPhone - sorry - if needed I’ll send longer email from my desk later.
——

On 19 Oct 2018, at 06:15, SharkyKZ notifications@github.com wrote:

@SharkyKZ commented on this pull request.

In administrator/components/com_actionlogs/controllers/actionlogs.php:

@@ -116,6 +116,9 @@ public function exportLogs()
*/
public function purge()
{

  • // Check for request forgeries.
    
  • $this->checkToken();
    

Remove tabs.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar SharkyKZ
SharkyKZ - comment - 19 Oct 2018

tabs

avatar SharkyKZ
SharkyKZ - comment - 19 Oct 2018

I have tested this item successfully on 81efaf7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22705.

avatar SharkyKZ SharkyKZ - test_item - 19 Oct 2018 - Tested successfully
avatar zero-24
zero-24 - comment - 19 Oct 2018

Merging thanks.

avatar zero-24 zero-24 - change - 19 Oct 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-19 12:30:52
Closed_By zero-24
avatar zero-24 zero-24 - close - 19 Oct 2018
avatar zero-24 zero-24 - merge - 19 Oct 2018

Add a Comment

Login with GitHub to post a comment