? Failure

User tests: Successful: Unsuccessful:

avatar JoomliC
JoomliC
18 Oct 2018

Pull Request for Issue #22627.
REDO #22674

Summary of Changes

  • Remove default attribute for loggable_extensions (Fix #22627 UX issue)
  • Add a "Select All/None" for loggable extensions to help selecting all or clearing all on one click.
  • Allow empty selection selection for actionlogs Notification Extensions

com_actionlogs global options
capture d ecran 2018-10-16 a 21 20 40

Super user edit view
capture d ecran 2018-10-18 a 16 32 48

Testing Instructions

  • See issue #22627
  • Install latest staging (needs merged PR #21983)
  • Test actions logging options in global options of com_actionlogs and in super user edit view. All selected, some selected, none selected.
avatar JoomliC JoomliC - open - 18 Oct 2018
avatar JoomliC JoomliC - change - 18 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Oct 2018
Category Administration Front End Plugins
avatar SharkyKZ
SharkyKZ - comment - 18 Oct 2018

Also make same changes to when new record is being inserted. You can try this code SharkyKZ@bfa85d7,

avatar SharkyKZ
SharkyKZ - comment - 18 Oct 2018

The JavaScript for all/none toggle needs an unique selector because now it affects all checkboxes fields on page.

avatar JoomliC JoomliC - change - 18 Oct 2018
Labels Added: ?
avatar JoomliC
JoomliC - comment - 18 Oct 2018

The JavaScript for all/none toggle needs an unique selector because now it affects all checkboxes fields on page.

Added field's ID to the javascript selector. Thanks!

Ready for tests

avatar franz-wohlkoenig franz-wohlkoenig - change - 18 Apr 2019
Title
[3.9][com_actionlogs] Improve UX for loggable extensions checkboxes with a select all/none
Improve UX for loggable extensions checkboxes with a select all/none
avatar franz-wohlkoenig franz-wohlkoenig - edited - 18 Apr 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 18 Apr 2019
Title
[3.9][com_actionlogs] Improve UX for loggable extensions checkboxes with a select all/none
Improve UX for loggable extensions checkboxes with a select all/none
avatar richard67
richard67 - comment - 1 Apr 2022

Closing in favour of #37446 which seems to be the better solution for the issue. Feel free to re-open this PR here if you think closing was wrong.

avatar richard67 richard67 - close - 1 Apr 2022
avatar richard67 richard67 - change - 1 Apr 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-04-01 13:30:34
Closed_By richard67
avatar cyrezdev
cyrezdev - comment - 1 Apr 2022

I had forgotten about this PR... :-D

But if you think the PR #37446 is a better solution... (not sure better than checkboxes when many extensions that could be logged...)

avatar brianteeman
brianteeman - comment - 1 Apr 2022

except the PR that @richard67 closed this in favour of was for j4.2 and this PR is for 3.x

Add a Comment

Login with GitHub to post a comment