? ? Success

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
18 Oct 2018

Pull Request for Issue # .

Summary of Changes

Create new user instance before clearing access rights cache so as not to clear it globally.

Testing Instructions

Code review.

avatar SharkyKZ SharkyKZ - open - 18 Oct 2018
avatar SharkyKZ SharkyKZ - change - 18 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Oct 2018
Category Front End Plugins
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Apr 2019
Title
[plg_system_actionlogs] Use new user instance
Use new user instance
avatar franz-wohlkoenig franz-wohlkoenig - edited - 19 Apr 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Apr 2019
Title
[plg_system_actionlogs] Use new user instance
Use new user instance
avatar viocassel viocassel - test_item - 2 Jul 2019 - Tested successfully
avatar viocassel
viocassel - comment - 2 Jul 2019

I have tested this item successfully on 56f7bc0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22697.

avatar alikon alikon - test_item - 2 Jul 2019 - Tested successfully
avatar alikon
alikon - comment - 2 Jul 2019

I have tested this item successfully on 56f7bc0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22697.

avatar alikon alikon - change - 2 Jul 2019
Status Pending Ready to Commit
avatar alikon
alikon - comment - 2 Jul 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22697.

avatar HLeithner
HLeithner - comment - 3 Jul 2019

@SharkyKZ whats the reason for this change?

avatar SharkyKZ
SharkyKZ - comment - 3 Jul 2019

It was a mistake on my part. We need to check new user access rights in this plugin but we shouldn't clear them on the global user instance as this could lead to undesirable behavior in code and other plugins that run after this one.

avatar HLeithner
HLeithner - comment - 3 Jul 2019

ok thx

avatar HLeithner HLeithner - change - 20 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-20 17:17:20
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 20 Jul 2019
avatar HLeithner HLeithner - merge - 20 Jul 2019
avatar HLeithner
HLeithner - comment - 20 Jul 2019

thx

Add a Comment

Login with GitHub to post a comment