User tests: Successful: Unsuccessful:
Info and Relationships
Local link destination does not exist
A local link (anchor link) occurs but the destination does not exist.
When using local links they must refer to an existing element on the page.
So changed the #collapse1 etc to simply #
role=Presentation
when a menu item is just a separator then the role is not menuitem
https://www.w3.org/TR/wai-aria/#presentation
collapsible menus
Should not have aria-hidden
Expandable menu
Should have aria-haspopup=true
Icons
icons on menu items should have aria-hidden="true"
Nav
The entire menu should be wrapped in a nav (not a div) and therefore we dont need role=navigation as it is implicit
Link Purpose (In Context)
The same link text is used for links going to different destinations eg "categories". Users might not know the difference if they are not somehow explained.
This should not be a problem as only unique links are exposed to the accessibility tree at any time
Accessibility testing tools may still report this as an issue
Extra markup??
data-toggle="dropdown"
I don't believe this is required any more but I have left it in for now and this can be addressed ion another PR
List-style-none
This needs to be explicitly set to none or the screenreader will announce "white bullet"
This is the only part of this pr that requires npm run build:css
everything else can be tested just with patchtester
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Administration Templates (admin) |
data-toggle="dropdown"
I don't believe this is required any more but I have left it in for now and this can be addressed ion another PR
Correct. Actually, I think this heralds from the bootsrap dropdown in J3.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-18 12:18:34 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
On discussion merging this for the alpha I plan on releasing today and we'll do the last few items in another PR
I will try and get some external a11y experts to test - there are a few bits that while correct I think can be improved further