Yes I'm repeating me: I would suggest to fork the fof method into some joomla API / lib (with mention the source) so we are not going to introduce another dependency on the deprecated / old FOF code.

Yeah, might as well do it now versus merging now with the FOF dependency then whenever this all merges forward to 4.0 having to rewrite it then since the library isn't present anymore.

Agree, especially as we removed FOF in J4.

well then, something like '/joomla/utilities/src/IpHelper.php' could be OK ?

If you're gonna put it at libraries/vendor/joomla/utilities/src/IpHelper.php then this needs to be a Framework pull request to https://github.com/joomla-framework/utilities

Otherwise to keep it in the CMS only move it to libraries/src/Utility/IpHelper.php with class name Joomla\CMS\Utility\IpHelper

(Not saying I prefer one over the other, though arguably it'd be better suited in the Framework package, but those are the two options and the work involved for each one)

i'm really slow ? sorry

joomla-framework/utilities#22

If you're going to do code (style) feedback on the IpHelper class, joomla-framework/utilities#22 would be a more efficient place to do that (please and thank you).

If you're going to do code (style) feedback on the IpHelper class, joomla-framework/utilities#22 would be a more efficient place to do that (please and thank you).

Sorry in bed on iphone :) Also "forker" text not in that patch

5153c83 has committed the bump on the Utilities package, so this PR needs updating to account for that.

closing in favor #22682