Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#22670] - [com_actionlogs] - detect correct IP address

? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
16 Oct 2018

Pull Request for Issue #22636 .

Summary of Changes

detect correct IP address using
forked FOFUtilsIp::getIp() with joomla-framework/utilities#22 to IpHelper::getIp()

Testing Instructions

apply #22673 before
see #22636

avatar alikon alikon - open - 16 Oct 2018
avatar alikon alikon - change - 16 Oct 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2018
Category ⇒ Administration
avatar zero-24
zero-24 - comment - 16 Oct 2018

I would suggest to fork this method into an joomla lib (we should keep an mention about that this origininal comes from FOF etc). so we are not going to add yet another dependency on that outdated fof version.

avatar alikon alikon - change - 16 Oct 2018
Labels Added: ?
avatar alikon alikon - change - 16 Oct 2018
The description was changed
avatar alikon alikon - edited - 16 Oct 2018
avatar mbabker
mbabker - comment - 16 Oct 2018

5153c83 has committed the bump on the Utilities package, so this is now testable against current staging if you patch the modified files.

avatar PhilETaylor
PhilETaylor - comment - 19 Oct 2018

I have tested this item ✅ successfully on d8d7e6d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22670.

avatar PhilETaylor PhilETaylor - test_item - 19 Oct 2018 - Tested successfully
avatar mbabker mbabker - close - 24 Oct 2018
avatar mbabker mbabker - merge - 24 Oct 2018
avatar mbabker mbabker - change - 24 Oct 2018
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-10-24 01:35:44
Closed_By ⇒ mbabker

Add a Comment

Login with GitHub to post a comment