J4 Issue ?
avatar brianteeman
brianteeman
16 Oct 2018

The module is supposed to support the ability to view the password by clicking on the eye but when you do you get the following error for the site module

Uncaught TypeError: Cannot read property 'nextElementSibling' of null
    at HTMLSpanElement.<anonymous> (passwordview.min.js?a41cbebf78ce21eda724838de8f977ba:1)
(anonymous) @ passwordview.min.js?a41cbebf78ce21eda724838de8f977ba:1

and this error for the admin module

Uncaught TypeError: Cannot set property 'type' of null
    at HTMLSpanElement.<anonymous> (passwordview.min.js?a41cbebf78ce21eda724838de8f977ba:1)
(anonymous) @ passwordview.min.js?a41cbebf78ce21eda724838de8f977ba:1

Spotted this while trying to fix some a11y errors with it but I cant do that while there is this js error and I dont have the js skill to debug/fix

avatar brianteeman brianteeman - open - 16 Oct 2018
avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 16 Oct 2018
avatar brianteeman brianteeman - change - 16 Oct 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 16 Oct 2018
avatar brianteeman brianteeman - change - 16 Oct 2018
Title
[4.0] Login module - frontend
[4.0] Login module - password view
avatar brianteeman brianteeman - edited - 16 Oct 2018
avatar brianteeman brianteeman - change - 16 Oct 2018
The description was changed
avatar brianteeman brianteeman - edited - 16 Oct 2018
avatar brianteeman brianteeman - change - 16 Oct 2018
The description was changed
avatar brianteeman brianteeman - edited - 16 Oct 2018
avatar brianteeman
brianteeman - comment - 16 Oct 2018

The only place it does work correctly is administrator/index.php?option=com_users&view=user&layout=edit

avatar C-Lodder
C-Lodder - comment - 16 Oct 2018

I see the issue. Will submit a PR later

avatar laoneo
laoneo - comment - 16 Oct 2018

I'm on it already

avatar brianteeman brianteeman - change - 16 Oct 2018
Status New Closed
Closed_Date 0000-00-00 00:00:00 2018-10-16 12:30:58
Closed_By brianteeman
avatar brianteeman brianteeman - close - 16 Oct 2018
avatar C-Lodder
C-Lodder - comment - 16 Oct 2018

@laoneo Can I suggest the login module actually utilises the password/text layouts first and then the JS is fixed accordingly?

avatar brianteeman
brianteeman - comment - 16 Oct 2018

To be honest the way this JS works appears to be a hard coding to a specific markup. I thought the entire point of layouts etc was to free a designer from specific hard requirements like this. We're just swapping one well supported and cohesive framework for a hotch porch of hacked together scripts that still place restrictions.

avatar laoneo
laoneo - comment - 16 Oct 2018

Please comment on #22666. I tried to decouple it as much as possible from the structure

Add a Comment

Login with GitHub to post a comment