[#22660] - Import from database dump only imports first table
- Fixed in Code Base
- 19 Aug 2019
- Medium
- Build: staging
- # 22660
- Diff
- gslitt91:staging
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Import from database dump only imports first table .
Pull Request for Issue #22620.
Summary of Changes
On expression inside foreach
Testing Instructions
1. Export structure dump for more then one table.
2. Merge from dump generated in step one .
Expected result
it shall merge all tables .
Actual result
it only merges first table
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
franz-wohlkoenig
- 
Every change here should eventually make it to the Framework package if the same issue exists in a similar block of code. That goes for all Framework packages, not just the database.
Someone screwed up copy/pasting something, code that never had test coverage to detect the typo in the first place, someone mistyped it when creating it, who knows.
Well, I will care and make PR's against framework db package sooner or later. The typo is already fixed there in 2.0-dev, the change from this PR neither in master nor in 2.0-dev.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-19 15:22:53 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Removed:
J3 Issue
|
||
@HLeithner The correction from this PR and the typo I've mentioned in our Glip discussion have been merged now in the framework database package in both the master branch and the 2.0-dev branch. As soon as a composer update is made to the latest version of joomla/database, these changes are in 4.0-dev branch here. I've pinged Brian to update his PR #25840 for updating dependencies. If he will not do it, I will do a PR later after his PR has been merged. An update will fetch us also other recent changes e.g. for PHP 7.4 (array curly brackets).
Thanks Richard for managing this patch.
@mbabker Shouldn't this change not be also made in the framework? It seems in the framework there is also a typo in the function name "getAlterTableql", but in the CMS (J3) there is not this typo. See here the framework: https://github.com/joomla-framework/database/blob/master/src/DatabaseImporter.php#L264