? Pending

User tests: Successful: Unsuccessful:

avatar imanickam
imanickam
16 Oct 2018

Pull Request for Issue # https://issues.joomla.org/tracker/joomla-cms/22658

Summary of Changes

File: en-GB.ini
Location: \administrator\language\en-GB

Current Language String:
JHELP_MENUS_MENU_ITEM_PRIVACY_CREATE_REQUEST=" Menus_Menu_Item_Privacy_Create_Request"

Expected Language String:
JHELP_MENUS_MENU_ITEM_PRIVACY_CREATE_REQUEST="Menus_Menu_Item_Privacy_Create_Request"

Without the change (ie. with the leading space in the language value), Runtime Exception would occur in the Help screen.

Removing the leading space in the language value will display the correct Help screen.

Testing Instructions

(i) New Menu Item
(a) Create a new menu item of the type Create Request (This menu item type is under the group Privacy)
(b) After choosing the menu item of the type Create Request, in the resultant screen (Menus: New Item) click on the button Help

(ii) Existing Menu Item
(a) Open a menu item of the type Create Request for Edit
(b) In the resultant screen (Menus: Edit Item) click on the button Help

In both the cases (i) and (ii) the following Help screen with the error will show, as seen in the section Actual result.

Expected result

correct_help_screen_after_removing_leading_space_in_language_value

Actual result

error_help_screen_with_leading_space_in_language_value

Documentation Changes Required

Due to the leading space in the language string value, the Help screen URL created is:
https://help.joomla.org/proxy?keyref=Help39:%20Menus_Menu_Item_Privacy_Create_Request&lang=en

This URL would result in:
RuntimeException
Error fetching page from MediaWiki API.

With the leading space removed in the language string value, the Help screen URL created is:
https://help.joomla.org/proxy?keyref=Help39:Menus_Menu_Item_Privacy_Create_Request&lang=en

The URL would result in:
Menus Menu Item Privacy Create Request

avatar imanickam imanickam - open - 16 Oct 2018
avatar imanickam imanickam - change - 16 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2018
Category Administration Language & Strings
avatar imanickam imanickam - change - 16 Oct 2018
The description was changed
avatar imanickam imanickam - edited - 16 Oct 2018
avatar infograf768
infograf768 - comment - 16 Oct 2018

I have tested this item successfully on 709866a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22658.

avatar infograf768 infograf768 - test_item - 16 Oct 2018 - Tested successfully
avatar infograf768 infograf768 - change - 16 Oct 2018
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 16 Oct 2018

Obvious error. RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22658.

avatar infograf768 infograf768 - close - 16 Oct 2018
avatar infograf768 infograf768 - merge - 16 Oct 2018
avatar infograf768 infograf768 - change - 16 Oct 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-16 05:20:17
Closed_By infograf768
Labels Added: ?
avatar infograf768
infograf768 - comment - 16 Oct 2018

@imanickam
Please inform TTs of this change.

avatar imanickam
imanickam - comment - 16 Oct 2018

Done.

Add a Comment

Login with GitHub to post a comment