[#22645] - Formfield layouts
- Fixed in Code Base
- 26 Feb 2019
- Medium
- Build: staging
- # 22645
- Diff
- phproberto:formfield-layouts
- Success Hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
This is a resubmission of #13018 because I totally abandoned @Spudley which is the worst I could do with a new contributor :( I'm really sorry mate and I hope you get your contribution merged at least 2 years later. I created a custom email rule for the repo notifications and everything is messed there.
This pull request adds the default layout paths to FormField::getLayoutPaths() so developers can inherit them and add any custom layout path required by their extensions.
Before this patch a developer wanting to set custom layout paths had to do something like:
protected function getLayoutPaths()
{
$renderer = new FileLayout('default');
return array_merge(
array(__DIR__ . '/custom-dir'),
$renderer->getDefaultIncludePaths())
}After this patch it should be easier like:
protected function getLayoutPaths()
{
return array_merge(
[__DIR__ . '/custom-dir'],
parent::getLayoutPaths()
);
}which should be better because:
- Parent cares about default include paths.
- Child classes do not have to explicitly create an instance of
FileLayout
This also adds unit tests for FormField::getLayoutPaths().
Testing Instructions
Edit any form containing fields (for instance com_content article) and ensure that form fields are shown correctly.
If you want ot test layout paths customisation you can create a field like it's done in the tests:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Unit Tests |
| Labels |
Added:
?
?
|
||
I have tested this item
Tested following the testing instructions, on a localhost, xampp, win10, and the testfield.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22645.
I have tested this item
Working as intended leaving this to @HLeithner for an merge.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22645.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22645.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-26 13:22:30 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
thx
thank you
I have tested this item✅ successfully on 683cd61
Tested following the testing instructions, on a localhost, xampp, win10, and the testfield.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22645.