Feeling Lucky
?
[#22642] - [4.0] Router factory service
- Closed
- 13 Jun 2019
- Medium
- Build: 4.0-dev
- # 22642
- Diff
- Digital-Peak:j4/service/router
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
RouterFactory service similar to #16449. Additionally a cleanup is made as the static function getRouter from the application is called in a none static way.
Testing Instructions
Browse around on the front and back end.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_finder Libraries Plugins |
| Labels |
Added:
?
|
||
laoneo
- comment
- 17 Oct 2018
If they are in the same namespace you don't need to add the import for these classes as they are imported automatically. I didn't import only in the classes of the namesapce Joomla\CMS\Router.
brianteeman
- comment
- 17 Oct 2018
Thank you for the explanation.
| Labels |
Added:
Conflicting Files
|
||
| Labels |
Removed:
Conflicting Files
|
||
bonzani
- comment
- 18 Jan 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22642.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-13 13:12:00 |
| Closed_By | ⇒ | laoneo |
Maybe my misunderstanding but only in some files where you have added
RouterFactoryInterfaceyou have also addeduse Joomla\CMS\Router\RouterFactoryInterface;Shouldn't it be in all?