? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
15 Oct 2018

Pull Request for Issue #22621

Summary of Changes

If an extension name has been saved as uppercase
or
if the extension name language string is not present in its .ini file but only in its .sys.ini file
The name of the extension is not translated in the log manager.

This patch makes sure the lang file concerned is loaded.

Test

Test update and install such extensions. (Uninstalling would anyway delete the lang files and force the display to use the <name> , for exemple com_something)

@SharkyKZ

avatar infograf768 infograf768 - open - 15 Oct 2018
avatar infograf768 infograf768 - change - 15 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Oct 2018
Category Administration
avatar PhilETaylor
PhilETaylor - comment - 15 Oct 2018

Did you run a quick test with JCE Editor? IIRC they do something different with their extension name

avatar infograf768
infograf768 - comment - 15 Oct 2018

JCE looks fine with this PR, except for the package itself.

The string is present in pkg_jce_2633/language/en-GB/en-GB.pkg_jce.sys.ini
but the code in the loadTranslationFiles($extension) method does not provide for this case.

screen shot 2018-10-15 at 18 05 21

avatar PhilETaylor
PhilETaylor - comment - 15 Oct 2018

Excellent news :)

avatar infograf768
infograf768 - comment - 15 Oct 2018

I wonder though if it is possible to add such a case. When JCE is installed, the result in the installation manager is coming from
COM_JCE_XML_DESCRIPTION="<p>JCE is a WYSIWYG Editor Extension for Joomla based on Moxiecode's <a href='http://tinymce.moxiecode.com' target='_blank' />TinyMCE</a> editor.</p><p>JCE would not exist without these great projects:<br /><ul><li><a href='http://www.joomla.org' target='_blank'>Joomla!</a></li><li><a href='http://tinymce.moxiecode.com' target='_blank'>TinyMCE</a></li><li><a href='http://jquery.com' target='_blank'>JQuery</a></li><li><a href='http://getuikit.com/' target='_blank'>UIKit</a></li><li>Fugue Icons Copyright © <a href='http://p.yusukekamiyamane.com/'>Yusuke Kamiyamane.</a> All rights reserved.</ul></p><p>JCE is dedicated to my father.</p><p>For a full changelog see <a target='_blank' href='https://www.joomlacontenteditor.net/support/changelog/editor'>https://www.joomlacontenteditor.net/support/changelog/editor</a></p>"

and not from the package language file.

EDIT: In any case, the <name> in JCE's component manifest is uppercase. Therefore this patch is absolutely necessary.

avatar PhilETaylor
PhilETaylor - comment - 15 Oct 2018

yup - I have much experience in getting the translated extension names and you will find example after example of 3pd doing some 'interesting' things that need working around if it's to be rock solid.

my current code is belt and braces (and has J1.5.x workarounds too)
https://github.com/PhilETaylor/myjoomla-connector/blob/master/bfnetwork/bfExtensions.php#L191

avatar infograf768
infograf768 - comment - 16 Oct 2018

That's overkill imho, and not taking care of packages. ?

I found that JCE is storing its en-GB.pkg_jce.sys.ini in the frontend language folder.
But I do not know if the placement there as well as the name of the package PKG_JCE are standards.
If it's only JCE, no use to make it a special case in our method.

avatar PhilETaylor
PhilETaylor - comment - 16 Oct 2018

no use to make it a special case in our method.

Like I said, there will be LOTS of these "special cases" over time ;-) 3pd do all kinds of wonderful and weird things :) Good luck ! :-)

avatar alikon
alikon - comment - 19 Oct 2018

I have tested this item successfully on 9c8df72


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22637.

avatar alikon alikon - test_item - 19 Oct 2018 - Tested successfully
avatar laoneo
laoneo - comment - 19 Oct 2018

I have tested this item successfully on 9c8df72


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22637.

avatar laoneo laoneo - test_item - 19 Oct 2018 - Tested successfully
avatar mbabker mbabker - close - 19 Oct 2018
avatar mbabker mbabker - merge - 19 Oct 2018
avatar mbabker mbabker - change - 19 Oct 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-19 12:04:33
Closed_By mbabker
Labels Added: ?

Add a Comment

Login with GitHub to post a comment