? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 Oct 2018

Pr for #19434

See comment from @wilsonge #15136 (comment) as to why it is not being 100% removed

avatar brianteeman brianteeman - open - 14 Oct 2018
avatar brianteeman brianteeman - change - 14 Oct 2018
Status New Pending
avatar wilsonge wilsonge - change - 14 Oct 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-14 23:10:42
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 14 Oct 2018
avatar wilsonge wilsonge - merge - 14 Oct 2018
avatar wilsonge
wilsonge - comment - 14 Oct 2018

Thanks!

avatar mbabker
mbabker - comment - 14 Oct 2018

The lock file's missing...

avatar brianteeman
brianteeman - comment - 14 Oct 2018

I didnt know I was supposed to commit that :(

Should I do a new pr for that?

avatar brianteeman
brianteeman - comment - 14 Oct 2018
avatar mbabker
mbabker - comment - 14 Oct 2018

I didnt know I was supposed to commit that :(

Should I do a new pr for that?

Same as composer.lock, should be committed because that's tracking the actual dependency versions to use, not just declared supported ranges.

Add a Comment

Login with GitHub to post a comment