[#22611] - [4.0] Missing css
- Fixed in Code Base
- 14 Oct 2018
- Medium
- Build: 4.0-dev
- # 22611
- Diff
- brianteeman:21982-redo
User tests: Successful: Unsuccessful:
Pull Request for Issue #22529 .
Summary of Changes
Make sure there is a border bottom on all table header cells
It got removed somewhere????
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-14 21:29:20 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks
@brianteeman figured out why I removed it. Under the header there was inconsistent underlines. And whilst we can add the underscore under the checkbox - I didn't see the need for two single pixel lines so I decided to remove it.
and removing it produces the error you highlight
Other way around. Adding this line in produces it (because the checkbox headers consistently aren't a th element but a td and therefore aren't underlined.
this pr added the underline to the td and the th
without this line you get the error - see screenshots
with the line you dont get the error - see screenshots
Apparently I removed it here. I'm sure there was a reason. But can't remember what now (and currently since my upgrade to Mojave this week localhost is broken). Will merge it for now and can figure out at a later point in time why.