Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#22608] - [privacy] Create only 1 domain for the items custom fields (simplify export xml)

? Pending

User tests: Successful: Unsuccessful:

avatar JoomliC
JoomliC
14 Oct 2018

Summary of Changes

Privacy information request: create only 1 domain for the items custom fields to simplify export xml.

Testing Instructions

  • Install Joomla 3.9.0 RC with sample data (or create some articles, contacts)
  • Create custom fields for article (do the same for contact, users).
  • Create a new user information export request in component Privacy (if none exists). Easier to create one for super user email address (sample data is created with super user as creator)
  • Export user information from request in privacy component before to apply this patch.
  • Check xml file for content_custom_fields, contact_custom_fields and users_custom_fields domains
    Result : 1 domain element is creating for each item.
  • Apply the patch
  • Export again the same user information request.
  • Check second xml file for content_custom_fields, contact_custom_fields and users_custom_fields domains
    Result : 1 domain element is creating for all items (simplify the view and readability of the export xml file).

Expected result

  <domain name="content_custom_fields" description="joomla_content_custom_fields_data">
    <item>
      <content_id>67</content_id>
      <field_name>test-custom-field</field_name>
      <field_title>Test Custom Field</field_title>
      <field_value/>
    </item>
    <item>
      <content_id>69</content_id>
      <field_name>test-custom-field</field_name>
      <field_title>Test Custom Field</field_title>
      <field_value/>
    </item>
    <item>
      <content_id>70</content_id>
      <field_name>test-custom-field</field_name>
      <field_title>Test Custom Field</field_title>
      <field_value>Test CF value</field_value>
    </item>
    <item>
      <content_id>6</content_id>
      <field_name>test-custom-field</field_name>
      <field_title>Test Custom Field</field_title>
      <field_value/>
    </item>
    [...]
  </domain>

Actual result

  <domain name="content_custom_fields" description="joomla_content_custom_fields_data">
    <item>
      <content_id>67</content_id>
      <field_name>test-custom-field</field_name>
      <field_title>Test Custom Field</field_title>
      <field_value/>
    </item>
  </domain>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data">
    <item>
      <content_id>69</content_id>
      <field_name>test-custom-field</field_name>
      <field_title>Test Custom Field</field_title>
      <field_value/>
    </item>
  </domain>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data">
    <item>
      <content_id>70</content_id>
      <field_name>test-custom-field</field_name>
      <field_title>Test Custom Field</field_title>
      <field_value>Test CF value</field_value>
    </item>
  </domain>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data">
    <item>
      <content_id>6</content_id>
      <field_name>test-custom-field</field_name>
      <field_title>Test Custom Field</field_title>
      <field_value/>
    </item>
  </domain>
  [...]
avatar JoomliC JoomliC - open - 14 Oct 2018
avatar JoomliC JoomliC - change - 14 Oct 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2018
Category ⇒ Administration Front End Plugins
avatar mbabker
mbabker - comment - 14 Oct 2018

If this doesn't merge for 3.9.0 then honestly we probably can't take it until 4.0 because it does change the exported schema structure.

avatar laoneo
laoneo - comment - 15 Oct 2018

Agree with @mbabker, so lets get some tests here.

avatar JoomliC
JoomliC - comment - 15 Oct 2018

Another test example with NO custom fields, could help to see current result VS expected result...

  • Install 3.9.0 RC with sample data
  • Create a frontend menu to generate a user privacy information request for email of super user
  • Go to admin to download the export xml file
  • Then install patch, and export again the xml file to see expected result.

Expected result

  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>

Actual result

  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>
  <domain name="content_custom_fields" description="joomla_content_custom_fields_data"/>

No custom fields for articles result in as many line for content_custom_fields as articles created by exported user.
(the same for contacts, but not issue with user custom fields, as only one user exported. This patch aims to manage array of item(s) to manage the contents/contacts as well as user exported custom fields)

Let's imagine the user has created 1000 articles, with no custom fields... ;-)

avatar mbabker
mbabker - comment - 17 Oct 2018

I have tested this item ✅ successfully on 2a79839

Important note: Make sure you have at least two articles for the user whose data is being exported, otherwise you'll be like me and spend 10 minutes trying to recreate the issue.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22608.

avatar mbabker mbabker - test_item - 17 Oct 2018 - Tested successfully
avatar JoomliC JoomliC - change - 17 Oct 2018
The description was changed
avatar JoomliC JoomliC - edited - 17 Oct 2018
avatar JoomliC
JoomliC - comment - 17 Oct 2018

Important note: Make sure you have at least two articles for the user whose data is being exported, otherwise you'll be like me and spend 10 minutes trying to recreate the issue.

I have added the info to install with sample data in my last post, but i've forgotten to mention it on PR testing instructions. I've updated it! Thanks!

avatar infograf768
infograf768 - comment - 17 Oct 2018

I have tested this item ✅ successfully on 2a79839

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22608.

avatar infograf768 infograf768 - test_item - 17 Oct 2018 - Tested successfully
avatar infograf768 infograf768 - change - 17 Oct 2018
Status Pending ⇒ Ready to Commit
avatar infograf768
infograf768 - comment - 17 Oct 2018

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22608.

avatar laoneo laoneo - change - 17 Oct 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-10-17 06:00:58
Closed_By ⇒ laoneo
Labels Added: ?
avatar laoneo laoneo - close - 17 Oct 2018
avatar laoneo laoneo - merge - 17 Oct 2018
avatar JoomliC
JoomliC - comment - 17 Oct 2018

Thanks!

Add a Comment

Login with GitHub to post a comment