[#22601] - Remove INSTL_DATABASE_EMPTY_NAME string
- Fixed in Code Base
- 14 Oct 2018
- Medium
- Build: staging
- # 22601
- Diff
- Bakual:RemoveUnusedEmptyString
User tests: Successful: Unsuccessful:
That's a bit a strange one. In the installation language files we have a string INSTL_DATABASE_EMPTY_NAME which has no value.
It is used in the installation model in a check if a database name is provided. However that check can't be triggered to my knowledge since the database field is already checked with JavaScript and the form can't be submitted without that required field.
Also, apparently nobody noticed that this string isn't translated during the last 8+ years.
If that code check really is needed, then we should add a value to the string
Summary of Changes
Removes the check in the model and the strings in the language files
Testing Instructions
Test installation and especially submitting without a database name.
Expected result
Works as always
Actual result
Works as always
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation Language & Strings |
Yeah, but with completely wrong values
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-14 16:03:20 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
?
|
||
even stranger that 5 languages have managed to translate this empty strong