[#22596] - [4.0] Workflows and stages: Remove checkin buttons
- Closed
- 13 Oct 2018
- Medium
- Build: 4.0-dev
- # 22596
- Diff
- chmst:workflow-toolbar-checkout
User tests: Successful: Unsuccessful:
Summary of Changes
Workflows and stages do not have checkout fields, therefore the checkin buttons are superfluous.
Testing Instructions
See workflows and stages view before and after patch,
Documentation Changes Required
yes
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_workflow |
This is a bigger change. So we should have more opinions there? @wilsonge, @bembelimen ?
It's not actually too bad. We just need to add the fields into the database table and everything else should be picked up automatically. My gut is we should probably have checked out support (the entire purpose of this is to avoid simultaneous edits and I don't see why this shouldn't apply to workflows) any other thoughts
All right, thank you for your opinion.
The changes are in the database (and sample data) and the tables of the views. I will do it in the next days.
So this PR can be closed.
Quy
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-13 23:30:06 |
| Closed_By | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/22596
| Closed_Date | 2018-10-13 23:30:06 | ⇒ | 2018-10-13 23:30:08 |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
Wondering if instead of removing the button we should instead be adding the functionality - as far as i am aware everything else has a checked out field