? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
11 Oct 2018

as its only deleted by script.php once installed anyway and is just a duplicate GPL v2 License

Part of #22219

avatar PhilETaylor PhilETaylor - open - 11 Oct 2018
avatar PhilETaylor PhilETaylor - change - 11 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Oct 2018
Category External Library Libraries
avatar mbabker
mbabker - comment - 11 Oct 2018

Actually the line should be removed from the delete array, not the file removed from the repo. Especially in the case of a third party's LICENSE file...

avatar PhilETaylor
PhilETaylor - comment - 11 Oct 2018

So you want to keep multiple versions of the GPL text?

avatar PhilETaylor PhilETaylor - change - 11 Oct 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-10-11 11:53:57
Closed_By PhilETaylor
Labels Added: ?
avatar PhilETaylor PhilETaylor - close - 11 Oct 2018
avatar mbabker
mbabker - comment - 11 Oct 2018

We keep the license file for every external package we pull in (check libraries/vendor), even though that results in several copies of at least the GPL and MIT licenses being included. The other option is to concatenate and have a single LICENSE file for the entire distribution with the text of all applicable licenses.

avatar PhilETaylor
PhilETaylor - comment - 11 Oct 2018

No worries - forked to #22585

Add a Comment

Login with GitHub to post a comment