? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
11 Oct 2018

Pull Request for Issue #22515
Thanks @csthomas for the code to not use the db query

Summary of Changes

Adding $lang parameter to the target menu item when site is multilingual

Testing Instructions

Create a multilingual site. 2 languages are enough.
Use multiple menu items in both languages
Among them create an Alias menu item to a menu item tagged to the other language.
Click on the Alias menu item in frontend.

Before patch

The menu item may display but with the wrong language interface

After patch

Issue solved. One is redirected to the menu item in the other language.

Warning

This will NOT work when not using the core menu module.
It does not break 3rd party menu solutions but they will lack this improvement.

@B3nito
@HLeithner
@csthomas

avatar infograf768 infograf768 - open - 11 Oct 2018
avatar infograf768 infograf768 - change - 11 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Oct 2018
Category Modules Front End
avatar infograf768 infograf768 - change - 11 Oct 2018
The description was changed
avatar infograf768 infograf768 - edited - 11 Oct 2018
avatar infograf768 infograf768 - change - 11 Oct 2018
Labels Added: ?
8704980 11 Oct 2018 avatar infograf768 oops
avatar csthomas
csthomas - comment - 11 Oct 2018

I have tested this item successfully on 8704980


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22579.

avatar csthomas csthomas - test_item - 11 Oct 2018 - Tested successfully
avatar Quy
Quy - comment - 11 Oct 2018

I have tested this item successfully on 8704980


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22579.

avatar Quy Quy - test_item - 11 Oct 2018 - Tested successfully
avatar Quy Quy - change - 11 Oct 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 11 Oct 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22579.

avatar mbabker mbabker - change - 24 Oct 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-24 01:38:19
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 24 Oct 2018
avatar mbabker mbabker - merge - 24 Oct 2018
avatar olejenya
olejenya - comment - 9 Nov 2018

What does happen? http://prntscr.com/lg8r9y

Add a Comment

Login with GitHub to post a comment