[#22572] - Fix the return url in the login form
- Closed
- 12 Jun 2022
- Medium
- Build: staging
- # 22572
- Diff
- cdekok:fix-return-url-login
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
… of the full url https://...
This fixes the return page after login.
The full url option was removed due to a security fix according to this page: https://docs.joomla.org/How_do_you_redirect_users_after_a_successful_login%3F#Overriding
Summary of Changes
Changed the return url to be index.php?Itemid=x instead of the full url.
Testing Instructions
Visit a restricted page, login and you are returned to the correct page, which is broken on the current 3.8.x
Expected result
You are returned to the previous page.
Actual result
You are returned to the homepage.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
It does not work for me on 3.8.13 i do use the login form from the component, not the module.
Do you have a multilingual website?
Yes correct this was on a multilingual site
I am sorry but I can not help. I'm very busy. New job and long commutes take me a lot of time.
adtj93
- 
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22572.
| Labels |
Added:
?
?
Removed: ? |
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22572.
| Labels |
Added:
?
?
Removed: ? |
||
Within this call we also could have post parameters which should not be added to the URL as they could contain sensitive data. I will close here for that reason and keep the current behavior for j3.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-12 18:51:50 |
| Closed_By | ⇒ | zero-24 |
Here is a similar change which I suggest in https://github.com/joomla/joomla-cms/pull/22229/files#diff-a17a2f629f4567e156880f91bff86ea9
You test instruction is unclear. J3.8 should work with not relative URLs.