User tests: Successful: Unsuccessful:
Pull Request for Issue #22555
Using current url when Active Languages is set to display in the language switcher module and there is no specific menu item for the page.
See #22555
Create a multilingual site. Associate articles or not.
Make sure you set Active Language to Yes in the language switcher module.
Create a blog menu item (or list) for articles, but do NOT create any single article menu item.
Click on the title of one of these articles to display it by itself.
In the language switcher module, click on the language or flag for the current language.
The link obtained may load the original menu item (in that case the blog or list enu item).
The link is the current link. It will reload the current page.
We could very easily not add any link in that case, but it would look weird to get a flag or a language name among the others with no action when clicking on it.
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Front End |
Labels |
Added:
?
|
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-09 16:12:08 |
Closed_By | ⇒ | infograf768 |
Status | Closed | ⇒ | New |
Closed_Date | 2018-10-09 16:12:08 | ⇒ | |
Closed_By | infograf768 | ⇒ |
Status | New | ⇒ | Pending |
@Giuse69
PR reopened after code corrections. Please test all possibilities (dropdown or not, image or not, show language active or not in each case possible)
At this stage, I have kept a link (corrected) for the active language without adding a parameter to use or not such link in order to be B/C.
The active language has anyway a class lang-active
for people who want to customise further.
We can introduce indeed a new parameter in 4.0 to add that link or not.
Note: J4.0 is very late concerning porting staging modifications. Nothing among the new stuff for multingual sites in staging/3.9.0 has been yet ported to 4.0
No, that is not that yet.
We should have nothing there instead of <li></li>
as we can get into a bad display when the active language is between 2 non active ones.
I guess it should now be Ok.
Please test...
I have tested this item
I reverted the change JFilterOutput::ampReplace
as this will not do the job.
The method replaces single &
by &
which is not what we want.
OK, now we get back ampersands as &
and still use htmlspecialchars
for quotes.
Thanks for testing.
I have tested this item
I have tested this (as per the testing instructions) successfully on a multilingual site that has English and Tamil (தமிழ்) as content languages.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-25 11:43:29 |
Closed_By | ⇒ | mbabker |
this PR has been cancelled to be done under another id?
I like also the idea of current language flag not to be a link: displaying current language is anyway useful to show which is current language (maybe with a CSS style to highlight the lang-active class) but what is the purpose to click on current language? Even it may be more correct of not being clickable since there is nowhere to go to.
Maybe an option in the language switcher module to have active language as a link or not?
By the way, J4.0 is already fixed for this?