? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
8 Oct 2018

Pull Request for Issue #22551 .

Summary of Changes

translate to backend url

Testing Instructions

#22551

avatar alikon alikon - open - 8 Oct 2018
avatar alikon alikon - change - 8 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Oct 2018
Category Administration
avatar alikon alikon - change - 8 Oct 2018
Labels Added: ?
avatar alikon
alikon - comment - 8 Oct 2018

3 lines of code 2 @Quy yellow card collected ?
?

avatar Quy
Quy - comment - 8 Oct 2018

I have tested this item successfully on 25258a3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22554.

avatar Quy Quy - test_item - 8 Oct 2018 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 8 Oct 2018

Perhaps move this to the plugin? And add component check?

avatar infograf768
infograf768 - comment - 9 Oct 2018

@alikon
@SharkyKZ is right. This should depend on the plugin.

I propose this as a solution.

diff --git a/plugins/actionlog/joomla/joomla.php b/plugins/actionlog/joomla/joomla.php
index 0fb7e27..2d06e50 100644
--- a/plugins/actionlog/joomla/joomla.php
+++ b/plugins/actionlog/joomla/joomla.php
@@ -78,5 +78,12 @@
 		}
 
-		list(, $contentType) = explode('.', $params->type_alias);
+		if ($option === 'com_content')
+		{
+			$contentType = 'article';
+		}
+		else
+		{
+			list(, $contentType) = explode('.', $params->type_alias);
+		}
 
 		if ($isNew)
@@ -191,5 +198,12 @@
 		}
 
-		list(, $contentType) = explode('.', $params->type_alias);
+		if ($option === 'com_content')
+		{
+			$contentType = 'article';
+		}
+		else
+		{
+			list(, $contentType) = explode('.', $params->type_alias);
+		}
 
 		switch ($value)
@@ -470,4 +484,9 @@
 		$option = $this->app->input->getCmd('option');
 
+		if ($table->get('module') != null)
+		{
+			$option = 'com_modules';
+		}
+
 		if (!$this->checkLoggable($option))
 		{

avatar infograf768
infograf768 - comment - 9 Oct 2018

Oh, I see it contains the check for com_modules which is already taken care in another PR.
I will merge that one now.

avatar infograf768
infograf768 - comment - 9 Oct 2018

@alikon
can you modify PR?
RC is for tomorrow

avatar Quy Quy - change - 9 Oct 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-10-09 15:23:07
Closed_By Quy
avatar joomla-cms-bot
joomla-cms-bot - comment - 9 Oct 2018

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/22554

avatar joomla-cms-bot joomla-cms-bot - change - 9 Oct 2018
Closed_Date 2018-10-09 15:23:07 2018-10-09 15:23:08
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 9 Oct 2018

Add a Comment

Login with GitHub to post a comment