J3 Issue ?
avatar infograf768
infograf768
8 Oct 2018

Steps to reproduce the issue

Use some single quotes in the administrator/language/en-GB/en-GB.plg_quickicon_privacycheck.ini

Expected result

Singlequotes should not be escaped, as done correctly for extensionupdate strings.

Actual result (with French strings)

screen shot 2018-10-08 at 12 10 20

screen shot 2018-10-08 at 12 10 26

avatar infograf768 infograf768 - open - 8 Oct 2018
avatar joomla-cms-bot joomla-cms-bot - change - 8 Oct 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 8 Oct 2018
avatar infograf768
infograf768 - comment - 8 Oct 2018

By changing true to false in

		$options  = array(
			'plg_quickicon_privacycheck_url'      => Uri::base() . $privacy . '&view=requests&filter[status]=1&list[fullordering]=a.requested_at ASC',
			'plg_quickicon_privacycheck_ajax_url' => Uri::base() . $privacy . '&task=getNumberUrgentRequests&' . $token,
			'plg_quickicon_privacycheck_text'     => array(
				"NOREQUEST"            => Text::_('PLG_QUICKICON_PRIVACYCHECK_NOREQUEST', true),
				"REQUESTFOUND"         => Text::_('PLG_QUICKICON_PRIVACYCHECK_REQUESTFOUND', true),
				"REQUESTFOUND_MESSAGE" => Text::_('PLG_QUICKICON_PRIVACYCHECK_REQUESTFOUND_MESSAGE', true),
				"REQUESTFOUND_BUTTON"  => Text::_('PLG_QUICKICON_PRIVACYCHECK_REQUESTFOUND_BUTTON', true),
				"ERROR"                => Text::_('PLG_QUICKICON_PRIVACYCHECK_ERROR', true),
			)
		);

It solves the issue. (taking off true would also work as $jsSafe is false by default)).
Looks weird to me as it is not used this way for extension update.

@mbabker ?

avatar infograf768
infograf768 - comment - 8 Oct 2018

will make pr

avatar brianteeman brianteeman - change - 9 Oct 2018
Labels Added: J3 Issue
avatar brianteeman brianteeman - labeled - 9 Oct 2018
avatar infograf768
infograf768 - comment - 9 Oct 2018

closing as we have patch
#22557

avatar infograf768 infograf768 - change - 9 Oct 2018
Status New Closed
Closed_Date 0000-00-00 00:00:00 2018-10-09 07:41:25
Closed_By infograf768
avatar infograf768 infograf768 - close - 9 Oct 2018

Add a Comment

Login with GitHub to post a comment