? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
8 Oct 2018

Summary of Changes

This PR just correct the primary (unique) key for the workflow association tables. The stage ID should not be part of the key, because otherwise you could add something like: (1, 1, 'com_content'), (1, 2, 'com_content'), which is not correct.

Testing Instructions

Install Joomla!, should behave as before.

avatar bembelimen bembelimen - open - 8 Oct 2018
avatar bembelimen bembelimen - change - 8 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Oct 2018
Category SQL Administration com_admin Postgresql Installation
avatar bembelimen bembelimen - change - 8 Oct 2018
The description was changed
avatar bembelimen bembelimen - edited - 8 Oct 2018
avatar richard67
richard67 - comment - 9 Oct 2018

@bembelimen Can it be you have forgotten a word "not" in your description?

The stage ID should not be part of the key, because otherwise you could add something like: (1, 1, 'com_content'), (1, 2, 'com_content'), which is not correct.

If you have the stage ID in the primary key (PK), you can't add those examples, if you don't have the stage ID in your PK, you can add them.

And "otherwise" refers to the opposite of the part of the sentence before that, and so it means that the stage ID would be part of the PK.

So I think you meant:

The stage ID should not be part of the key, because otherwise you could not add something like: (1, 1, 'com_content'), (1, 2, 'com_content'), which is not correct.

Correct me if I'm wrong.

avatar csthomas
csthomas - comment - 9 Oct 2018

Each item (item_id, extension) can have only one stage, ex 'published'.

Why are there so many index keys? At least one key is redundant (idx_item_id).

avatar richard67
richard67 - comment - 9 Oct 2018

@csthomas So this PR is wrong?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22547.

avatar csthomas
csthomas - comment - 9 Oct 2018

PR is correct.

On the other hand I do not like this table #__workflow_associations at all.
It seems to be better to add additional column stage_id in #__content and remove this table at all.

avatar richard67
richard67 - comment - 9 Oct 2018

@bembelimen Forget my comment to you above at the top. I was confused somehow. Your description is correct.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22547.

avatar richard67
richard67 - comment - 9 Oct 2018

I have tested this item successfully on d347650


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22547.

avatar richard67
richard67 - comment - 9 Oct 2018

I have tested this item successfully on d347650


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22547.

avatar richard67 richard67 - test_item - 9 Oct 2018 - Tested successfully
avatar wilsonge wilsonge - change - 10 Oct 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-10 12:55:31
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 10 Oct 2018
avatar wilsonge wilsonge - merge - 10 Oct 2018
avatar wilsonge
wilsonge - comment - 10 Oct 2018

Thanks!

Add a Comment

Login with GitHub to post a comment