[#22540] - [4.0] Hide column default for trashed stages
- Closed
- 19 Nov 2018
- Medium
- Build: 4.0-dev
- # 22540
- Diff
- chmst:workflow-stages-trash
User tests: Successful: Unsuccessful:
Summary of Changes
Hide the column "Default" in stages list, when Filter is "trashed", so that trashed items cannot be set as default
Testing Instructions
Go to the stages overview of a workflow.
Trash one or more items.
Use the filter trashed and see the overview of trashed items.
Expected result
The column default is now invisible if the filter is "trashed"
Actual result
The column "Default" is visible and you can set a trashed item to default.
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_workflow |
| Labels |
Added:
?
|
||
It is true that we cannot have different behaviour. For me it feels better to hide functions everywhere when they are useless. We could do this in menu as well?
what do you when you set the filter to all?
I would hide the icon for trashed items
Closing this. I will make a new PR.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-19 10:08:10 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
Conflicting Files
|
||
I understand why you are doing this but it feels wrong to show/hide columns when the status changes
We don't do the same for trashed menu items to prevent them being set as default